Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2701523004:
Add DumpWithoutCrashing in RendererDidNavigateToExistingPage (Closed)
DescriptionAdd DumpWithoutCrashing in RendererDidNavigateToExistingPage
This is intended to be reverted after investigating the linked bug.
BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2701523004
Cr-Commit-Position: refs/heads/master@{#450900}
Committed: https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5936bd71a583a
Patch Set 1 #Patch Set 2 : fix origin conditional' #
Total comments: 2
Patch Set 3 : jam comments #Messages
Total messages: 20 (13 generated)
Description was changed from ========== Add DumpWithoutCrashing in RendererDidNavigateToExistingPage This is intended to be reverted after investigating the linked bug. BUG=688425 ========== to ========== Add DumpWithoutCrashing in RendererDidNavigateToExistingPage This is intended to be reverted after investigating the linked bug. BUG=688425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
estark@chromium.org changed reviewers: + jam@chromium.org, nasko@chromium.org
jam or nasko, PTAL?
lgtm perhaps also add the URL so we can try to repro?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
https://codereview.chromium.org/2701523004/diff/20001/content/browser/frame_h... File content/browser/frame_host/navigation_controller_impl.cc (right): https://codereview.chromium.org/2701523004/diff/20001/content/browser/frame_h... content/browser/frame_host/navigation_controller_impl.cc:1100: new_entry = GetLastCommittedEntry()->CloneAndReplace( also maybe here as well?
The CQ bit was checked by estark@chromium.org to run a CQ dry run
On 2017/02/16 03:59:16, jam wrote: > lgtm > > perhaps also add the URL so we can try to repro? Done. Thanks! https://codereview.chromium.org/2701523004/diff/20001/content/browser/frame_h... File content/browser/frame_host/navigation_controller_impl.cc (right): https://codereview.chromium.org/2701523004/diff/20001/content/browser/frame_h... content/browser/frame_host/navigation_controller_impl.cc:1100: new_entry = GetLastCommittedEntry()->CloneAndReplace( On 2017/02/16 04:34:37, jam wrote: > also maybe here as well? Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by estark@chromium.org
The CQ bit was checked by estark@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/2701523004/#ps40001 (title: "jam comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487226618915370,
"parent_rev": "e95efe684e5a75a1a39cdc0d9fddde301911cd05", "commit_rev":
"c32cd2069ae8062b52e5b7b1faf5936bd71a583a"}
Message was sent while issue was closed.
Description was changed from ========== Add DumpWithoutCrashing in RendererDidNavigateToExistingPage This is intended to be reverted after investigating the linked bug. BUG=688425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Add DumpWithoutCrashing in RendererDidNavigateToExistingPage This is intended to be reverted after investigating the linked bug. BUG=688425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2701523004 Cr-Commit-Position: refs/heads/master@{#450900} Committed: https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2711533002/ by jam@chromium.org. The reason for reverting is: We got the data we wanted.. |
