Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2711413002: Reland of Fix up javac.py's depfile to include all relevant inputs (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix up javac.py's depfile to include all relevant inputs The missing .jar files was broken a while ago by: https://codereview.chromium.org/1730993002 But it never contained the javac binary Reverted in: https://codereview.chromium.org/2712973002/ Reason for reland: Now works with enable_incremental_javac=true BUG=589311, 695441 Review-Url: https://codereview.chromium.org/2711413002 Cr-Commit-Position: refs/heads/master@{#452923} Committed: https://chromium.googlesource.com/chromium/src/+/453ee830bdd7e8a3ac3f05c0f348deb75f35f4ae

Patch Set 1 #

Patch Set 2 : Fix typo in _ConvertToJMakeArgs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M build/android/gyp/javac.py View 1 4 chunks +11 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
agrieve
Created Reland of Fix up javac.py's depfile to include all relevant inputs
3 years, 10 months ago (2017-02-24 18:44:01 UTC) #1
nyquist
lgtm
3 years, 10 months ago (2017-02-24 19:23:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711413002/40001
3 years, 10 months ago (2017-02-24 19:44:39 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 21:22:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/453ee830bdd7e8a3ac3f05c0f348...

Powered by Google App Engine
This is Rietveld 408576698