Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2712973002: Revert of Fix up javac.py's depfile to include all relevant inputs (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix up javac.py's depfile to include all relevant inputs (patchset #2 id:20001 of https://codereview.chromium.org/2712453003/ ) Reason for revert: Broke enable_incremental_javac GN arg Original issue's description: > Fix up javac.py's depfile to include all relevant inputs > > The missing .jar files was broken a while ago by: > https://codereview.chromium.org/1730993002 > > But it never contained the javac binary > > BUG=589311 > > Review-Url: https://codereview.chromium.org/2712453003 > Cr-Commit-Position: refs/heads/master@{#452156} > Committed: https://chromium.googlesource.com/chromium/src/+/df82b88ea4aa22520083f90922a99540902f666e TBR=nyquist@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589311, 695441 Review-Url: https://codereview.chromium.org/2712973002 Cr-Commit-Position: refs/heads/master@{#452485} Committed: https://chromium.googlesource.com/chromium/src/+/a38190340ae16cb9043857f9ef85eea193ded7f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M build/android/gyp/javac.py View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
agrieve
Created Revert of Fix up javac.py's depfile to include all relevant inputs
3 years, 10 months ago (2017-02-23 14:51:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712973002/1
3 years, 10 months ago (2017-02-23 14:51:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a38190340ae16cb9043857f9ef85eea193ded7f5
3 years, 10 months ago (2017-02-23 14:53:18 UTC) #7
agrieve
3 years, 10 months ago (2017-02-24 18:44:00 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2711413002/ by agrieve@chromium.org.

The reason for reverting is: will update.

Powered by Google App Engine
This is Rietveld 408576698