Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2712453003: Fix up javac.py's depfile to include all relevant inputs (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up javac.py's depfile to include all relevant inputs The missing .jar files was broken a while ago by: https://codereview.chromium.org/1730993002 But it never contained the javac binary BUG=589311 Review-Url: https://codereview.chromium.org/2712453003 Cr-Commit-Position: refs/heads/master@{#452156} Committed: https://chromium.googlesource.com/chromium/src/+/df82b88ea4aa22520083f90922a99540902f666e

Patch Set 1 #

Patch Set 2 : don't need to add processors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/android/gyp/javac.py View 1 3 chunks +10 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
nyquist
lgtm
3 years, 10 months ago (2017-02-22 11:16:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712453003/20001
3 years, 10 months ago (2017-02-22 19:01:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/df82b88ea4aa22520083f90922a99540902f666e
3 years, 10 months ago (2017-02-22 19:12:00 UTC) #16
agrieve
3 years, 10 months ago (2017-02-23 14:51:10 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2712973002/ by agrieve@chromium.org.

The reason for reverting is: Broke enable_incremental_javac GN arg.

Powered by Google App Engine
This is Rietveld 408576698