Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2710963002: Reland of Fall back to default media device from preferences if no default is supplied from the c... (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fall back to default media device from preferences if no default is supplied from the command line. (patchset #1 id:1 of https://codereview.chromium.org/2713653002/ ) Reason for revert: Will try to reland with an update to the broken test. Original issue's description: > Revert of Fall back to default media device from preferences if no default is supplied from the command line. (patchset #1 id:20001 of https://codereview.chromium.org/2707033003/ ) > > Reason for revert: > Speculative revert to see if this causes https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65668/ to time out in a WebRTC-related test. > > Original issue's description: > > If no command-line default device is provided, fall back to reading it > > from preferences instead of acting as if there was no default device. > > > > This affects only the case when the command-line flag "--use-fake-device-for-media-stream" is supplied. > > > > BUG=693746 > > > > Review-Url: https://codereview.chromium.org/2707033003 > > Cr-Commit-Position: refs/heads/master@{#451995} > > Committed: https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20 > > TBR=tommi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=693746 > > Review-Url: https://codereview.chromium.org/2713653002 > Cr-Commit-Position: refs/heads/master@{#452035} > Committed: https://chromium.googlesource.com/chromium/src/+/0e05c9b817a75ba6fa1d24d2a9921121ccae80f9 TBR=tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=693746 Review-Url: https://codereview.chromium.org/2710963002 Cr-Commit-Position: refs/heads/master@{#452102} Committed: https://chromium.googlesource.com/chromium/src/+/c05af3853cd658ebc009b0a351267622ee77ecb3

Patch Set 1 #

Patch Set 2 : original patch, no changes #

Patch Set 3 : Specify default device IDs for broken test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/media/media_devices_util.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Guido Urdaneta
Created Reland of Fall back to default media device from preferences if no default is ...
3 years, 10 months ago (2017-02-22 16:09:40 UTC) #1
hbos_chromium
lgtm
3 years, 10 months ago (2017-02-22 16:27:48 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-22 16:28:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710963002/60001
3 years, 10 months ago (2017-02-22 17:11:04 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:15:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c05af3853cd658ebc009b0a35126...

Powered by Google App Engine
This is Rietveld 408576698