Chromium Code Reviews
DescriptionReland of Fall back to default media device from preferences if no default is supplied from the command line. (patchset #1 id:1 of https://codereview.chromium.org/2713653002/ )
Reason for revert:
Will try to reland with an update to the broken test.
Original issue's description:
> Revert of Fall back to default media device from preferences if no default is supplied from the command line. (patchset #1 id:20001 of https://codereview.chromium.org/2707033003/ )
>
> Reason for revert:
> Speculative revert to see if this causes https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65668/ to time out in a WebRTC-related test.
>
> Original issue's description:
> > If no command-line default device is provided, fall back to reading it
> > from preferences instead of acting as if there was no default device.
> >
> > This affects only the case when the command-line flag "--use-fake-device-for-media-stream" is supplied.
> >
> > BUG=693746
> >
> > Review-Url: https://codereview.chromium.org/2707033003
> > Cr-Commit-Position: refs/heads/master@{#451995}
> > Committed: https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20
>
> TBR=tommi@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693746
>
> Review-Url: https://codereview.chromium.org/2713653002
> Cr-Commit-Position: refs/heads/master@{#452035}
> Committed: https://chromium.googlesource.com/chromium/src/+/0e05c9b817a75ba6fa1d24d2a9921121ccae80f9
TBR=tommi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=693746
Review-Url: https://codereview.chromium.org/2710963002
Cr-Commit-Position: refs/heads/master@{#452102}
Committed: https://chromium.googlesource.com/chromium/src/+/c05af3853cd658ebc009b0a351267622ee77ecb3
Patch Set 1 #Patch Set 2 : original patch, no changes #Patch Set 3 : Specify default device IDs for broken test #
Messages
Total messages: 13 (8 generated)
|
||||||||||||||||||||||||||||