Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2713653002: Revert of Fall back to default media device from preferences if no default is supplied from the command line. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fall back to default media device from preferences if no default is supplied from the command line. (patchset #1 id:20001 of https://codereview.chromium.org/2707033003/ ) Reason for revert: Speculative revert to see if this causes https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65668/ to time out in a WebRTC-related test. Original issue's description: > If no command-line default device is provided, fall back to reading it > from preferences instead of acting as if there was no default device. > > This affects only the case when the command-line flag "--use-fake-device-for-media-stream" is supplied. > > BUG=693746 > > Review-Url: https://codereview.chromium.org/2707033003 > Cr-Commit-Position: refs/heads/master@{#451995} > Committed: https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20 TBR=tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693746 Review-Url: https://codereview.chromium.org/2713653002 Cr-Commit-Position: refs/heads/master@{#452035} Committed: https://chromium.googlesource.com/chromium/src/+/0e05c9b817a75ba6fa1d24d2a9921121ccae80f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M content/browser/media/media_devices_util.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Guido Urdaneta
Created Revert of Fall back to default media device from preferences if no default is ...
3 years, 10 months ago (2017-02-22 14:15:16 UTC) #2
Guido Urdaneta
3 years, 10 months ago (2017-02-22 16:09:39 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2710963002/ by guidou@chromium.org.

The reason for reverting is: Will try to reland with an update to the broken
test..

Powered by Google App Engine
This is Rietveld 408576698