Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2707033003: Fall back to default media device from preferences if no default is supplied from the command line. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If no command-line default device is provided, fall back to reading it from preferences instead of acting as if there was no default device. This affects only the case when the command-line flag "--use-fake-device-for-media-stream" is supplied. BUG=693746 Review-Url: https://codereview.chromium.org/2707033003 Cr-Commit-Position: refs/heads/master@{#451995} Committed: https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20

Patch Set 1 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/browser/media/media_devices_util.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Guido Urdaneta
Hi, PTAL
3 years, 10 months ago (2017-02-22 10:20:22 UTC) #6
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-22 10:24:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707033003/20001
3 years, 10 months ago (2017-02-22 11:14:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20
3 years, 10 months ago (2017-02-22 11:19:53 UTC) #14
Guido Urdaneta
3 years, 10 months ago (2017-02-22 14:15:15 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2713653002/ by guidou@chromium.org.

The reason for reverting is: Speculative revert to see if this causes
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65668/
to time out in a WebRTC-related test..

Powered by Google App Engine
This is Rietveld 408576698