Fall back to default media device from preferences if no default is supplied from the command line.

If no command-line default device is provided, fall back to reading it
from preferences instead of acting as if there was no default device.

This affects only the case when the command-line flag "--use-fake-device-for-media-stream" is supplied.

BUG=693746
Review-Url: https://codereview.chromium.org/2707033003
Cr-Commit-Position: refs/heads/master@{#451995}
Committed: https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa62f941c2bd20

[Guido Urdaneta, 2017-02-22 10:05:14]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2017-02-22 10:05:53]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 10:06:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-02-22 10:08:32]

Description was changed from

==========
Use command-line default media device only if one is provided.

If no command-line default device is provided, fall back to reading it
from preferences instead of acting as if there was no default device.

BUG=693746
==========

to

==========
If no command-line default device is provided, fall back to reading it
from preferences instead of acting as if there was no default device.

This affects only the case when the command-line flag
"--use-fake-device-for-media-stream" is supplied.

BUG=693746
==========

[Guido Urdaneta, 2017-02-22 10:20:11]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org

[Guido Urdaneta, 2017-02-22 10:20:22]

Hi, PTAL

[tommi (sloooow) - chröme, 2017-02-22 10:24:18]

lgtm

[commit-bot: I haz the power, 2017-02-22 11:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:13:47]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-02-22 11:14:25]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 11:18:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487762065606270,
"parent_rev": "2983702295c09219200a9252efde2734c26ca2b0", "commit_rev":
"2c5c012360a9213b6895ce6c79fa62f941c2bd20"}

[commit-bot: I haz the power, 2017-02-22 11:19:52]

Description was changed from

==========
If no command-line default device is provided, fall back to reading it
from preferences instead of acting as if there was no default device.

This affects only the case when the command-line flag
"--use-fake-device-for-media-stream" is supplied.

BUG=693746
==========

to

==========
If no command-line default device is provided, fall back to reading it
from preferences instead of acting as if there was no default device.

This affects only the case when the command-line flag
"--use-fake-device-for-media-stream" is supplied.

BUG=693746

Review-Url: https://codereview.chromium.org/2707033003
Cr-Commit-Position: refs/heads/master@{#451995}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa...
==========

[commit-bot: I haz the power, 2017-02-22 11:19:53]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c5c012360a9213b6895ce6c79fa...

[Guido Urdaneta, 2017-02-22 14:15:15]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2713653002/ by guidou@chromium.org.

The reason for reverting is: Speculative revert to see if this causes
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65668/
to time out in a WebRTC-related test..