Get rid of unused functions VisibleSelection::setBase and setExtent taking Position

Get rid of unused functions VisibleSelection::setBase and setExtent taking Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2710943002
Cr-Commit-Position: refs/heads/master@{#452252}
Committed: https://chromium.googlesource.com/chromium/src/+/08b74323568c102885a43073f95765b53f700ab8

[yosin_UTC9, 2017-02-22 13:10:06]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 13:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-22 13:11:39]

Description was changed from

==========
2017-02-22T22:07:34

BUG=
==========

to

==========
2708823003 Make SelecitonModifier class not to use VisibleSelection::setBase()
and setExtent()

This patch makes |SelecitonModifier| class not to use |Position| version of
|setBase()| and |setExtent()| of |VisibleSelection| as a preparation of
making |VisibleSelection| immutable for improving code health.

The concept of this patch is creating new |VisibleSelection| from
|m_selection| and copying back to |m_selection| instead of modifying
|m_selection| by using |setBase()| and |setExtent()|.

This is done by decomposing |willModify()| into |isBaseFirst()|,
returns true if |SelecitonModifier| uses selection start as base of new
selection, and |prepareForExtend()| to return new |VisibleSelection| from
start and end positions of passed |VisibleSelection|.

Since |setBase()| and |setExtent()| call |VisibleSelection:::validate()|,
the original code calls |validate()| twice, but this patch calls once.


Get rid of unused functions VisibleSelection::setBase and setExtent taking
Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-22 13:11:57]

Description was changed from

==========
2708823003 Make SelecitonModifier class not to use VisibleSelection::setBase()
and setExtent()

This patch makes |SelecitonModifier| class not to use |Position| version of
|setBase()| and |setExtent()| of |VisibleSelection| as a preparation of
making |VisibleSelection| immutable for improving code health.

The concept of this patch is creating new |VisibleSelection| from
|m_selection| and copying back to |m_selection| instead of modifying
|m_selection| by using |setBase()| and |setExtent()|.

This is done by decomposing |willModify()| into |isBaseFirst()|,
returns true if |SelecitonModifier| uses selection start as base of new
selection, and |prepareForExtend()| to return new |VisibleSelection| from
start and end positions of passed |VisibleSelection|.

Since |setBase()| and |setExtent()| call |VisibleSelection:::validate()|,
the original code calls |validate()| twice, but this patch calls once.


Get rid of unused functions VisibleSelection::setBase and setExtent taking
Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Get rid of unused functions VisibleSelection::setBase and setExtent taking
Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-22 13:12:32]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-22 13:12:32]

PTAL

[commit-bot: I haz the power, 2017-02-22 14:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 14:37:05]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-02-22 17:41:28]

lgtm

[tkent, 2017-02-22 22:47:09]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:48:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:55:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487803629514080, "parent_rev":
"fb44f95ae59019ed4317b15b0a1d57bbbfabd3ec", "commit_rev":
"08b74323568c102885a43073f95765b53f700ab8"}

[commit-bot: I haz the power, 2017-02-22 22:56:31]

Description was changed from

==========
Get rid of unused functions VisibleSelection::setBase and setExtent taking
Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Get rid of unused functions VisibleSelection::setBase and setExtent taking
Position

This patch gets rid of unused functions, |setBase()| and |setExtent()| taking
|Position| in |VisibleSelection| to reduce source code size for improving code
health.

This is follow up of patch[2] which gets rid of usage of |setBase()| and
|setExtent()|.

[1] http://crrev.com/2708823003 Make SelecitonModifier class not to use
VisibleSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2710943002
Cr-Commit-Position: refs/heads/master@{#452252}
Committed:
https://chromium.googlesource.com/chromium/src/+/08b74323568c102885a43073f957...
==========

[commit-bot: I haz the power, 2017-02-22 22:56:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08b74323568c102885a43073f957...