Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2710943002: Get rid of unused functions VisibleSelection::setBase and setExtent taking Position (Closed)
Patch Set: 2017-02-22T22:07:34 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 3fbaa8bca533b8f6c230d15c11185b2b6f9f8179..60dde5079917b1ce9e4f93e082fbf2c60fe295b9 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -138,14 +138,6 @@ SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::asSelection()
template <typename Strategy>
void VisibleSelectionTemplate<Strategy>::setBase(
- const PositionTemplate<Strategy>& position) {
- DCHECK(!needsLayoutTreeUpdate(position));
- m_base = position;
- validate();
-}
-
-template <typename Strategy>
-void VisibleSelectionTemplate<Strategy>::setBase(
const VisiblePositionTemplate<Strategy>& visiblePosition) {
DCHECK(visiblePosition.isValid());
m_base = visiblePosition.deepEquivalent();
@@ -154,14 +146,6 @@ void VisibleSelectionTemplate<Strategy>::setBase(
template <typename Strategy>
void VisibleSelectionTemplate<Strategy>::setExtent(
- const PositionTemplate<Strategy>& position) {
- DCHECK(!needsLayoutTreeUpdate(position));
- m_extent = position;
- validate();
-}
-
-template <typename Strategy>
-void VisibleSelectionTemplate<Strategy>::setExtent(
const VisiblePositionTemplate<Strategy>& visiblePosition) {
DCHECK(visiblePosition.isValid());
m_extent = visiblePosition.deepEquivalent();
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698