Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2710943002: Get rid of unused functions VisibleSelection::setBase and setExtent taking Position (Closed)
Patch Set: 2017-02-22T22:07:34 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 static VisibleSelectionTemplate create(const SelectionTemplate<Strategy>&); 62 static VisibleSelectionTemplate create(const SelectionTemplate<Strategy>&);
63 63
64 SelectionType getSelectionType() const { return m_selectionType; } 64 SelectionType getSelectionType() const { return m_selectionType; }
65 65
66 void setAffinity(TextAffinity affinity) { m_affinity = affinity; } 66 void setAffinity(TextAffinity affinity) { m_affinity = affinity; }
67 TextAffinity affinity() const { return m_affinity; } 67 TextAffinity affinity() const { return m_affinity; }
68 68
69 // TODO(yosin): To make |VisibleSelection| as immutable object, we should 69 // TODO(yosin): To make |VisibleSelection| as immutable object, we should
70 // get rid of |setBase()| and |setExtent()| by replacing them with 70 // get rid of |setBase()| and |setExtent()| by replacing them with
71 // |createVisibleSelection()|. 71 // |createVisibleSelection()|.
72 void setBase(const PositionTemplate<Strategy>&);
73 void setBase(const VisiblePositionTemplate<Strategy>&); 72 void setBase(const VisiblePositionTemplate<Strategy>&);
74 void setExtent(const PositionTemplate<Strategy>&);
75 void setExtent(const VisiblePositionTemplate<Strategy>&); 73 void setExtent(const VisiblePositionTemplate<Strategy>&);
76 74
77 SelectionTemplate<Strategy> asSelection() const; 75 SelectionTemplate<Strategy> asSelection() const;
78 PositionTemplate<Strategy> base() const { return m_base; } 76 PositionTemplate<Strategy> base() const { return m_base; }
79 PositionTemplate<Strategy> extent() const { return m_extent; } 77 PositionTemplate<Strategy> extent() const { return m_extent; }
80 PositionTemplate<Strategy> start() const { return m_start; } 78 PositionTemplate<Strategy> start() const { return m_start; }
81 PositionTemplate<Strategy> end() const { return m_end; } 79 PositionTemplate<Strategy> end() const { return m_end; }
82 80
83 VisiblePositionTemplate<Strategy> visibleStart() const { 81 VisiblePositionTemplate<Strategy> visibleStart() const {
84 return createVisiblePosition( 82 return createVisiblePosition(
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 217
220 #ifndef NDEBUG 218 #ifndef NDEBUG
221 // Outside the WebCore namespace for ease of invocation from gdb. 219 // Outside the WebCore namespace for ease of invocation from gdb.
222 void showTree(const blink::VisibleSelection&); 220 void showTree(const blink::VisibleSelection&);
223 void showTree(const blink::VisibleSelection*); 221 void showTree(const blink::VisibleSelection*);
224 void showTree(const blink::VisibleSelectionInFlatTree&); 222 void showTree(const blink::VisibleSelectionInFlatTree&);
225 void showTree(const blink::VisibleSelectionInFlatTree*); 223 void showTree(const blink::VisibleSelectionInFlatTree*);
226 #endif 224 #endif
227 225
228 #endif // VisibleSelection_h 226 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698