Get rid of useless function VisibleSelection::updateIfNeeded()

Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

vs.updateIfNeeded()
==
vs = createVisibleSelection(vs.asSelection())

BUG=513568
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709973005
Cr-Commit-Position: refs/heads/master@{#453058}
Committed: https://chromium.googlesource.com/chromium/src/+/c05388c6fc37ef12cf3b11df405c8dbc631b8f70

[yosin_UTC9, 2017-02-24 10:19:26]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 10:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-24 10:23:24]

Description was changed from

==========
2017-02-24T18:51:43

2017-02-24T18:51:11

BUG=
==========

to

==========
Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

BUG=513568
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-24 10:24:23]

Description was changed from

==========
Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

BUG=513568
TEST=n/a; no behavior changes
==========

to

==========
Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

vs.updateIfNeeded()
==
vs = createVisibleSelection(vs.asSelection())

BUG=513568
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-24 10:24:52]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-24 10:24:53]

PTAL

[commit-bot: I haz the power, 2017-02-24 12:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 12:42:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-02-24 18:06:06]

https://codereview.chromium.org/2709973005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (left):

https://codereview.chromium.org/2709973005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:159:
frame().selection().updateIfNeeded();
Is this a mis-removal?

[yosin_UTC9, 2017-02-25 01:01:29]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 01:01:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-25 01:02:03]

PTAL

https://codereview.chromium.org/2709973005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (left):

https://codereview.chromium.org/2709973005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:159:
frame().selection().updateIfNeeded();
On 2017/02/24 at 18:06:06, Xiaocheng wrote:
> Is this a mis-removal?

Yes, good catch!
This is over removal. I should move this in another patch.

FrameSelection::updateIfNeeded() { m_selectionEditor->updateIfNeeded(); }
SelectionEditor::updateIfNeeded() { updateCacheVisibleSelectionIfNeeded(); }
FrameSelection::computeVisibleSelectionInDOMTree() ==
SelectionEditor::computeVisibleSelectionInDOMTree()
== updateCachedVisibleSelectionIfNeeded().

So, this is redundant since L160 calls
computeVisibleSelectionInDOMTreeDeprecated().

[commit-bot: I haz the power, 2017-02-25 01:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 01:03:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2017-02-25 01:58:13]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-02-25 01:58:14]

lgtm

[commit-bot: I haz the power, 2017-02-25 01:58:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 03:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487987893661180,
"parent_rev": "6dc58b5746363ddbb99addb4c06c69a385212b7d", "commit_rev":
"c05388c6fc37ef12cf3b11df405c8dbc631b8f70"}

[commit-bot: I haz the power, 2017-02-25 03:36:16]

Description was changed from

==========
Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

vs.updateIfNeeded()
==
vs = createVisibleSelection(vs.asSelection())

BUG=513568
TEST=n/a; no behavior changes
==========

to

==========
Get rid of useless function VisibleSelection::updateIfNeeded()

This patch gets rid of useless function |VisibleSelection::updateIfNeeded()|
by replacing to equivalent expression to reduce source code size for improving
code health and preparation of making |VisibleSelection| immutable.

vs.updateIfNeeded()
==
vs = createVisibleSelection(vs.asSelection())

BUG=513568
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709973005
Cr-Commit-Position: refs/heads/master@{#453058}
Committed:
https://chromium.googlesource.com/chromium/src/+/c05388c6fc37ef12cf3b11df405c...
==========

[commit-bot: I haz the power, 2017-02-25 03:36:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c05388c6fc37ef12cf3b11df405c...