Get rid of useless function VisibleSelection::updateIfNeeded()

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 138 matching lines @@
     m_editor->frame().selection().revealSelection(
         ScrollAlignment::alignToEdgeIfNeeded, RevealExtent);
   }
 }
 
 // When an event handler has moved the selection outside of a text control
 // we should use the target control's selection for this editing operation.
 // TODO(yosin): We should make |Editor::selectionForCommand()| to return
 // |SelectionInDOMTree| instead of |VisibleSelection|.
 VisibleSelection Editor::selectionForCommand(Event* event) {
-  frame().selection().updateIfNeeded();

[Xiaocheng, 2017/02/24 18:06:06]

Is this a mis-removal?

[yosin_UTC9, 2017/02/25 01:02:03]

Yes, good catch!
This is over removal. I should move this in another patch.

FrameSelection::updateIfNeeded() { m_selectionEditor->updateIfNeeded(); }
SelectionEditor::updateIfNeeded() { updateCacheVisibleSelectionIfNeeded(); }
FrameSelection::computeVisibleSelectionInDOMTree() ==
SelectionEditor::computeVisibleSelectionInDOMTree()
== updateCachedVisibleSelectionIfNeeded().

So, this is redundant since L160 calls
computeVisibleSelectionInDOMTreeDeprecated().

   VisibleSelection selection =
       frame().selection().computeVisibleSelectionInDOMTreeDeprecated();
   if (!event)
     return selection;
   // If the target is a text control, and the current selection is outside of
   // its shadow tree, then use the saved selection for that text control.
   TextControlElement* textControlOfSelectionStart =
       enclosingTextControl(selection.start());
   TextControlElement* textControlOfTarget =
       isTextControlElement(*event->target()->toNode())
@@ skipping 749 matching lines @@
 
   respondToChangedContents(newSelection);
 }
 
 static VisibleSelection correctedVisibleSelection(
     const VisibleSelection& passedSelection) {
   if (!passedSelection.base().isConnected() ||
       !passedSelection.extent().isConnected())
     return VisibleSelection();
   DCHECK(!passedSelection.base().document()->needsLayoutTreeUpdate());
-  VisibleSelection correctedSelection = passedSelection;
-  correctedSelection.updateIfNeeded();
-  return correctedSelection;
+  return createVisibleSelection(passedSelection.asSelection());
 }
 
 void Editor::unappliedEditing(UndoStep* cmd) {
   EventQueueScope scope;
 
   dispatchEditableContentChangedEvents(cmd->startingRootEditableElement(),
                                        cmd->endingRootEditableElement());
   dispatchInputEventEditableContentChanged(
       cmd->startingRootEditableElement(), cmd->endingRootEditableElement(),
       InputEvent::InputType::HistoryUndo, nullAtom,
@@ skipping 824 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
   visitor->trace(m_typingStyle);
 }
 
 }  // namespace blink