third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp - Issue 2709973005: Get rid of useless function VisibleSelection::updateIfNeeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2709973005: Get rid of useless function VisibleSelection::updateIfNeeded() (Closed)

Patch Set: 2017-02-25T10:01:23 Do not remove FrameSelection::updateIfNeeded() Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

index b7b041535dd8116f787aab960ee6dc15f520fb37..0b2fe466b9269423061422419cbc6a2e733475ee 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

@@ -479,7 +479,7 @@ TEST_F(VisibleSelectionTest, updateIfNeededWithShadowHost) {

document().updateStyleAndLayout();

// Simulates to restore selection from undo stack.

- selection.updateIfNeeded();

+ selection = createVisibleSelection(selection.asSelection());

EXPECT_EQ(Position(sample->firstChild(), 0), selection.start());

}

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('k') | no next file » | no next file with comments »