Expand FrameSeleciton::base() to increase chances of hoisting update layout

Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
and modify some explicit case use |computeVisibleSelectionInDOMTree()|.
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709793003
Cr-Commit-Position: refs/heads/master@{#451957}
Committed: https://chromium.googlesource.com/chromium/src/+/1886d611f3f71c0ebe55a6d8fc49a40297ef7f99

[yosin_UTC9, 2017-02-22 04:09:24]

Description was changed from

==========
2017-02-22T13:08:01

2017-02-22T13:07:54

BUG=
==========

to

==========
Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-22 04:09:30]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 04:10:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-22 06:54:45]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-22 06:54:46]

PTAL

Changes in core/editing/, core/page, and core/testing/

[tkent, 2017-02-22 07:40:45]

> Note: This is mechanical change to replace |selection().base()|
> by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
> Following patch will remove deprecated version.

This note looks false. This CL uses computeVisibleSelectionInDOMTree() in some
code.

lgtm anyway.

[yosin_UTC9, 2017-02-22 08:38:28]

Description was changed from

==========
Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
and modify some explicit case use |computeVisibleSelectionInDOMTree()|.
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-02-22 09:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:04:49]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-02-22 09:29:05]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-22 09:29:37]

On 2017/02/22 at 07:40:45, tkent wrote:
> > Note: This is mechanical change to replace |selection().base()|
> > by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
> > Following patch will remove deprecated version.
> 
> This note looks false. This CL uses computeVisibleSelectionInDOMTree() in some
code.
> 
> lgtm anyway.

Updated a description. Some manual changes for explicit case.

[commit-bot: I haz the power, 2017-02-22 09:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:38:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487755745490910, "parent_rev":
"63a3cc052b9d9ea410edf1419b3409e0561b0bb7", "commit_rev":
"1886d611f3f71c0ebe55a6d8fc49a40297ef7f99"}

[commit-bot: I haz the power, 2017-02-22 09:39:01]

Description was changed from

==========
Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
and modify some explicit case use |computeVisibleSelectionInDOMTree()|.
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::base() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::base()| to increase chance of hoisting
update layout.

Note: This is mechanical change to replace |selection().base()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().base()|
and modify some explicit case use |computeVisibleSelectionInDOMTree()|.
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2709793003
Cr-Commit-Position: refs/heads/master@{#451957}
Committed:
https://chromium.googlesource.com/chromium/src/+/1886d611f3f71c0ebe55a6d8fc49...
==========

[commit-bot: I haz the power, 2017-02-22 09:39:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1886d611f3f71c0ebe55a6d8fc49...