Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2709793003: Expand FrameSeleciton::base() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-22T13:08:01 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 // This function does not allow the selection to collapse. If the new 179 // This function does not allow the selection to collapse. If the new
180 // extent is resolved to the same position as the current base, this 180 // extent is resolved to the same position as the current base, this
181 // function will do nothing. 181 // function will do nothing.
182 void moveRangeSelectionExtent(const IntPoint&); 182 void moveRangeSelectionExtent(const IntPoint&);
183 void moveRangeSelection(const VisiblePosition& base, 183 void moveRangeSelection(const VisiblePosition& base,
184 const VisiblePosition& extent, 184 const VisiblePosition& extent,
185 TextGranularity); 185 TextGranularity);
186 186
187 TextGranularity granularity() const { return m_granularity; } 187 TextGranularity granularity() const { return m_granularity; }
188 188
189 Position base() const {
190 return computeVisibleSelectionInDOMTreeDeprecated().base();
191 }
192 Position extent() const { 189 Position extent() const {
193 return computeVisibleSelectionInDOMTreeDeprecated().extent(); 190 return computeVisibleSelectionInDOMTreeDeprecated().extent();
194 } 191 }
195 Position start() const { 192 Position start() const {
196 return computeVisibleSelectionInDOMTreeDeprecated().start(); 193 return computeVisibleSelectionInDOMTreeDeprecated().start();
197 } 194 }
198 195
199 // Returns true if specified layout block should paint caret. This function is 196 // Returns true if specified layout block should paint caret. This function is
200 // called during painting only. 197 // called during painting only.
201 bool shouldPaintCaret(const LayoutBlock&) const; 198 bool shouldPaintCaret(const LayoutBlock&) const;
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 349
353 } // namespace blink 350 } // namespace blink
354 351
355 #ifndef NDEBUG 352 #ifndef NDEBUG
356 // Outside the WebCore namespace for ease of invocation from gdb. 353 // Outside the WebCore namespace for ease of invocation from gdb.
357 void showTree(const blink::FrameSelection&); 354 void showTree(const blink::FrameSelection&);
358 void showTree(const blink::FrameSelection*); 355 void showTree(const blink::FrameSelection*);
359 #endif 356 #endif
360 357
361 #endif // FrameSelection_h 358 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698