third_party/WebKit/Source/core/editing/InputMethodController.cpp - Issue 2709793003: Expand FrameSeleciton::base() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2709793003: Expand FrameSeleciton::base() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-22T13:08:01 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

index 7ea8eddf77aaa70f6038d00a88f883508d7364c3..7e10ac38a9db2f689acefe74cd5e96ec2419b480 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

@@ -585,7 +585,8 @@ void InputMethodController::setComposition(

document().updateStyleAndLayoutIgnorePendingStylesheets();

// Find out what node has the composition now.

- Position base = mostForwardCaretPosition(frame().selection().base());

+ Position base = mostForwardCaretPosition(

+ frame().selection().computeVisibleSelectionInDOMTree().base());

Node* baseNode = base.anchorNode();

if (!baseNode || !baseNode->isTextNode())

return;