Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2709473002: [gin] Use access_mode in argument (Closed)

Created:
3 years, 10 months ago by peria
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use access_mode in argument in a constructor of IsolateHolder. gin::IsolateHolder has 3 types of constructors, and one of them igored an argument. This CL makes it to use |access_mode| in the argument. BUG=None Review-Url: https://codereview.chromium.org/2709473002 Cr-Commit-Position: refs/heads/master@{#451583} Committed: https://chromium.googlesource.com/chromium/src/+/29dbb9f56a2a5aee774146bffeb053b3b460ae02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M gin/isolate_holder.cc View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
peria
PTL. This issue was introduced in https://codereview.chromium.org/2660423003, and it could break isolate's behavior in multi-thread ...
3 years, 10 months ago (2017-02-20 07:01:50 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-20 09:23:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709473002/1
3 years, 10 months ago (2017-02-20 09:25:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/29dbb9f56a2a5aee774146bffeb053b3b460ae02
3 years, 10 months ago (2017-02-20 09:30:11 UTC) #14
haraken
3 years, 10 months ago (2017-02-20 09:32:45 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698