Atomics.wait throws when called on the main thread.

Atomics.wait throws when called on the main thread.

BUG=686604
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2660423003
Cr-Commit-Position: refs/heads/master@{#447639}
Committed: https://chromium.googlesource.com/chromium/src/+/feca6e8c3446e2cb514eb72ef14e9b4dd44df163

[binji, 2017-01-31 22:34:28]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:46:26]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-01 04:34:19]

lgtm with nit

https://codereview.chromium.org/2660423003/diff/1/gin/public/isolate_holder.h
File gin/public/isolate_holder.h (right):

https://codereview.chromium.org/2660423003/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:60: AllowAtomicsWaitMode atomics_wait_mode =
kAllowAtomicsWait);
no default arguments please

[haraken, 2017-02-01 04:34:36]

bindings LGTM

[binji, 2017-02-01 20:49:12]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:49:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 23:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:05:02]

Dry run: This issue passed the CQ dry run.

[binji, 2017-02-01 23:09:32]

https://codereview.chromium.org/2660423003/diff/1/gin/public/isolate_holder.h
File gin/public/isolate_holder.h (right):

https://codereview.chromium.org/2660423003/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:60: AllowAtomicsWaitMode atomics_wait_mode =
kAllowAtomicsWait);
On 2017/02/01 04:34:19, jochen (travelling til Feb 4) wrote:
> no default arguments please

Done.

[binji, 2017-02-01 23:09:38]

The CQ bit was checked by binji@chromium.org

[binji, 2017-02-01 23:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2660423003/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-02-01 23:10:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 23:16:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485990578552960,
"parent_rev": "5ea36c973a46c98262c61b5e1d7c8dd86038c857", "commit_rev":
"feca6e8c3446e2cb514eb72ef14e9b4dd44df163"}

[commit-bot: I haz the power, 2017-02-01 23:16:52]

Description was changed from

==========
Atomics.wait throws when called on the main thread.

BUG=686604
R=jochen@chromium.org
==========

to

==========
Atomics.wait throws when called on the main thread.

BUG=686604
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2660423003
Cr-Commit-Position: refs/heads/master@{#447639}
Committed:
https://chromium.googlesource.com/chromium/src/+/feca6e8c3446e2cb514eb72ef14e...
==========

[commit-bot: I haz the power, 2017-02-01 23:16:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/feca6e8c3446e2cb514eb72ef14e...