Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2703183002: Factor out gin::IsolateHolder's constructor

Created:
3 years, 10 months ago by peria
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out gin::IsolateHolder's constructor. Before this CL, gin::IsolateHolder was created in the constructor of V8PerIsolateData, and it is less useful to customized usages. This CL moves the creation of IsolateHolder out of V8PerIsolateData and make it more flexible. BUG=617892

Patch Set 1 : . #

Patch Set 2 : fix WorkerBackingThread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (11 generated)
peria
Patchset #1 (id:1) has been deleted
3 years, 10 months ago (2017-02-20 07:37:20 UTC) #1
peria
The CQ bit was checked by peria@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-20 07:41:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703183002/20001
3 years, 10 months ago (2017-02-20 07:41:48 UTC) #3
peria
Description was changed from ========== Factor out gin::IsolateHolder's constructor BUG= ========== to ========== Factor out ...
3 years, 10 months ago (2017-02-20 07:48:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 08:40:27 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/391649)
3 years, 10 months ago (2017-02-20 08:40:28 UTC) #6
peria
Description was changed from ========== Factor out gin::IsolateHolder's constructor. Before this CL, gin::IsolateHolder was created ...
3 years, 10 months ago (2017-02-20 08:48:18 UTC) #7
peria
The CQ bit was checked by peria@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-20 08:59:49 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703183002/40001
3 years, 10 months ago (2017-02-20 09:00:05 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-20 11:59:23 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 11:59:23 UTC) #11
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698