Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/debug/debug.cc

Issue 2709263002: [inspector] use BREAK_POSITION_ALIGNED for breakpoints (Closed)
Patch Set: little testcfg tuning Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/debugger-script.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 1359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 } 1370 }
1371 } 1371 }
1372 if (!EnsureDebugInfo(candidates[i])) return false; 1372 if (!EnsureDebugInfo(candidates[i])) return false;
1373 } 1373 }
1374 if (was_compiled) continue; 1374 if (was_compiled) continue;
1375 1375
1376 for (int i = 0; i < candidates.length(); ++i) { 1376 for (int i = 0; i < candidates.length(); ++i) {
1377 CHECK(candidates[i]->HasDebugInfo()); 1377 CHECK(candidates[i]->HasDebugInfo());
1378 Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo()); 1378 Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo());
1379 FindBreakablePositions(debug_info, start_position, end_position, 1379 FindBreakablePositions(debug_info, start_position, end_position,
1380 STATEMENT_ALIGNED, positions); 1380 BREAK_POSITION_ALIGNED, positions);
1381 } 1381 }
1382 return true; 1382 return true;
1383 } 1383 }
1384 UNREACHABLE(); 1384 UNREACHABLE();
1385 return false; 1385 return false;
1386 } 1386 }
1387 1387
1388 void Debug::RecordGenerator(Handle<JSGeneratorObject> generator_object) { 1388 void Debug::RecordGenerator(Handle<JSGeneratorObject> generator_object) {
1389 if (last_step_action() <= StepOut) return; 1389 if (last_step_action() <= StepOut) return;
1390 1390
(...skipping 1017 matching lines...) Expand 10 before | Expand all | Expand 10 after
2408 isolate_->Throw(*isolate_->factory()->NewEvalError( 2408 isolate_->Throw(*isolate_->factory()->NewEvalError(
2409 MessageTemplate::kNoSideEffectDebugEvaluate)); 2409 MessageTemplate::kNoSideEffectDebugEvaluate));
2410 } 2410 }
2411 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_); 2411 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_);
2412 isolate_->debug()->UpdateHookOnFunctionCall(); 2412 isolate_->debug()->UpdateHookOnFunctionCall();
2413 isolate_->debug()->side_effect_check_failed_ = false; 2413 isolate_->debug()->side_effect_check_failed_ = false;
2414 } 2414 }
2415 2415
2416 } // namespace internal 2416 } // namespace internal
2417 } // namespace v8 2417 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/inspector/debugger-script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698