Respect ios_automatically_manage_certs when building EG tests.

Respect ios_automatically_manage_certs when building EG tests.

When the ios_automatically_manage_certs variable is set to true,
restrict the number of different Bundle Identifiers are used by
the build (as they are currently limited to 10 free certs per day).

BUG=613543
Review-Url: https://codereview.chromium.org/2709223002
Cr-Commit-Position: refs/heads/master@{#452529}
Committed: https://chromium.googlesource.com/chromium/src/+/eb7eea750b9604ca75254a775f9d381514966196

[sdefresne, 2017-02-22 14:33:18]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 14:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-22 14:35:35]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-02-22 14:35:36]

Please take a look.

[sdefresne, 2017-02-22 14:35:47]

Description was changed from

==========
Respect ios_automatically_manage_certs when building EG tests.

When the ios_automatically_manage_certs variable is set to true,
restrict the number of different Bundle Identifiers are used by
the build (as they are currently limited to 10 free certs per day).

BUG=613543
==========

to

==========
Respect ios_automatically_manage_certs when building EG tests.

When the ios_automatically_manage_certs variable is set to true,
restrict the number of different Bundle Identifiers are used by
the build (as they are currently limited to 10 free certs per day).

BUG=613543
==========

[sdefresne, 2017-02-22 14:35:48]

sdefresne@chromium.org changed reviewers:
+ justincohen@google.com
- rohitrao@chromium.org

[sdefresne, 2017-02-22 14:36:27]

+justincohen: Please take a look.

-rohitrao: Sorry, keyboard memory, please ignore.

[justincohen, 2017-02-22 15:02:18]

justincohen@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2017-02-22 15:02:19]

https://codereview.chromium.org/2709223002/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2709223002/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:1394: "EXECUTABLE_NAME=gtest.generic-unit-test",
should gtest.generic..blah be shared somehwere?  Same below?

[commit-bot: I haz the power, 2017-02-22 15:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 15:35:55]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-02-23 10:56:15]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2017-02-23 10:57:42]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 10:57:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-23 10:57:59]

On 2017/02/22 15:02:19, justincohen wrote:
> https://codereview.chromium.org/2709223002/diff/1/build/config/ios/rules.gni
> File build/config/ios/rules.gni (right):
> 
>
https://codereview.chromium.org/2709223002/diff/1/build/config/ios/rules.gni#...
> build/config/ios/rules.gni:1394: "EXECUTABLE_NAME=gtest.generic-unit-test",
> should gtest.generic..blah be shared somehwere?  Same below?

Done.

[commit-bot: I haz the power, 2017-02-23 11:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:58:16]

Dry run: This issue passed the CQ dry run.

[justincohen, 2017-02-23 14:49:10]

lgtm

[sdefresne, 2017-02-23 14:54:49]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-02-23 14:54:51]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-02-23 14:55:16]

sdefresne@chromium.org changed reviewers:
- justincohen@google.com

[sdefresne, 2017-02-23 14:55:30]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org

[sdefresne, 2017-02-23 14:55:59]

dpranke/phajdan.jr: can one of you review the changes to src/testing as OWNERS?

[Dirk Pranke, 2017-02-23 17:08:20]

lgtm

[sdefresne, 2017-02-23 17:11:18]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-02-23 17:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:16:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487869878111480,
"parent_rev": "47c6658e306effae6981843a7352972048e7c7ef", "commit_rev":
"eb7eea750b9604ca75254a775f9d381514966196"}

[commit-bot: I haz the power, 2017-02-23 17:16:37]

Description was changed from

==========
Respect ios_automatically_manage_certs when building EG tests.

When the ios_automatically_manage_certs variable is set to true,
restrict the number of different Bundle Identifiers are used by
the build (as they are currently limited to 10 free certs per day).

BUG=613543
==========

to

==========
Respect ios_automatically_manage_certs when building EG tests.

When the ios_automatically_manage_certs variable is set to true,
restrict the number of different Bundle Identifiers are used by
the build (as they are currently limited to 10 free certs per day).

BUG=613543

Review-Url: https://codereview.chromium.org/2709223002
Cr-Commit-Position: refs/heads/master@{#452529}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb7eea750b9604ca75254a775f9d...
==========

[commit-bot: I haz the power, 2017-02-23 17:16:38]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eb7eea750b9604ca75254a775f9d...