Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: build/config/ios/ios_sdk.gni

Issue 2709223002: Respect ios_automatically_manage_certs when building EG tests. (Closed)
Patch Set: Address comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/toolchain/toolchain.gni") 5 import("//build/toolchain/toolchain.gni")
6 6
7 declare_args() { 7 declare_args() {
8 # SDK path to use. When empty this will use the default SDK based on the 8 # SDK path to use. When empty this will use the default SDK based on the
9 # value of use_ios_simulator. 9 # value of use_ios_simulator.
10 ios_sdk_path = "" 10 ios_sdk_path = ""
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 # You can also pass the value via "--args" parameter for "gn gen" command by 50 # You can also pass the value via "--args" parameter for "gn gen" command by
51 # using the syntax --args='additional_target_cpus=["arm"] target_cpu="arm64"'. 51 # using the syntax --args='additional_target_cpus=["arm"] target_cpu="arm64"'.
52 additional_target_cpus = [] 52 additional_target_cpus = []
53 } 53 }
54 54
55 assert(custom_toolchain == "" || additional_target_cpus == [], 55 assert(custom_toolchain == "" || additional_target_cpus == [],
56 "cannot define both custom_toolchain and additional_target_cpus") 56 "cannot define both custom_toolchain and additional_target_cpus")
57 57
58 use_ios_simulator = current_cpu == "x86" || current_cpu == "x64" 58 use_ios_simulator = current_cpu == "x86" || current_cpu == "x64"
59 59
60 ios_generic_test_bundle_id_suffix = "generic-unit-test"
61
60 # Initialize additional_toolchains from additional_target_cpus. Assert here 62 # Initialize additional_toolchains from additional_target_cpus. Assert here
61 # that the list does not contains $target_cpu nor duplicates as this would 63 # that the list does not contains $target_cpu nor duplicates as this would
62 # cause weird errors during the build. 64 # cause weird errors during the build.
63 additional_toolchains = [] 65 additional_toolchains = []
64 if (additional_target_cpus != []) { 66 if (additional_target_cpus != []) {
65 foreach(_additional_target_cpu, additional_target_cpus) { 67 foreach(_additional_target_cpu, additional_target_cpus) {
66 assert(_additional_target_cpu != target_cpu, 68 assert(_additional_target_cpu != target_cpu,
67 "target_cpu must not be listed in additional_target_cpus") 69 "target_cpu must not be listed in additional_target_cpus")
68 70
69 _toolchain = "//build/toolchain/mac:ios_clang_$_additional_target_cpu" 71 _toolchain = "//build/toolchain/mac:ios_clang_$_additional_target_cpu"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 ios_code_signing_identity = _ios_identities[0] 131 ios_code_signing_identity = _ios_identities[0]
130 } 132 }
131 133
132 if (ios_code_signing_identity == "") { 134 if (ios_code_signing_identity == "") {
133 print("Tried to prepare a device build without specifying a code signing") 135 print("Tried to prepare a device build without specifying a code signing")
134 print("identity and could not detect one automatically either.") 136 print("identity and could not detect one automatically either.")
135 print("TIP: Simulator builds don't require code signing...") 137 print("TIP: Simulator builds don't require code signing...")
136 assert(false) 138 assert(false)
137 } 139 }
138 } 140 }
OLDNEW
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698