Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: ios/chrome/test/earl_grey/chrome_ios_eg_test.gni

Issue 2709223002: Respect ios_automatically_manage_certs when building EG tests. (Closed)
Patch Set: Address comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
diff --git a/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni b/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
index b18a3579a5056091e598cbbcce5e942065a5466b..521856d2c888ec9045fc303ed18deeeaa6c0f986 100644
--- a/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
+++ b/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/mac/tweak_info_plist.gni")
+import("//build/config/ios/ios_sdk.gni")
import("//ios/build/chrome_build.gni")
import("//ios/public/provider/chrome/browser/build_config.gni")
import("//ios/third_party/earl_grey/ios_eg_test.gni")
@@ -130,7 +131,6 @@ template("chrome_ios_eg_test") {
extra_substitutions = []
}
extra_substitutions += [
- "CHROMIUM_BUNDLE_ID=gtest.$target_name",
"CHROMIUM_HANDOFF_ID=$chromium_handoff_id",
"CHROMIUM_SHORT_NAME=$target_name",
"CHROMIUM_URL_SCHEME_1=$url_unsecure_scheme",
@@ -140,5 +140,13 @@ template("chrome_ios_eg_test") {
"EG_MAIN_APPLICATION_DELEGATE=$_eg_main_application_delegate",
"SSOAUTH_URL_SCHEME=$url_ssoauth_scheme",
]
+ if (ios_automatically_manage_certs) {
+ # Use the same bundle identifier for EarlGrey tests as for unit tests
+ # when managing certificates as the number of free certs is limited.
+ extra_substitutions +=
+ [ "CHROMIUM_BUNDLE_ID=gtest.${ios_generic_test_bundle_id_suffix}" ]
+ } else {
+ extra_substitutions += [ "CHROMIUM_BUNDLE_ID=gtest.$target_name" ]
+ }
}
}
« no previous file with comments | « build/config/ios/rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698