Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2707023007: Verify that clearing browsing data clears permission embargo. (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
Reviewers:
msramek, Mike West
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify that clearing browsing data clears permission embargo. This CL improves the existing permission decision auto blocker tests in ChromeBrowsingDataRemoveDelegateTest. It verifies that multiple dismissals cause a permission to be embargoed, and that clearing history and clearing site data erases any existing embargo state. BUG=679877 Review-Url: https://codereview.chromium.org/2707023007 Cr-Commit-Position: refs/heads/master@{#452469} Committed: https://chromium.googlesource.com/chromium/src/+/99b1bb0927bf4837bccbe01498b76860e455485f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc View 10 chunks +48 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
dominickn
PTAL, thanks!
3 years, 10 months ago (2017-02-23 03:43:53 UTC) #4
dominickn
Swapping in mkwst for msramek. PTAL, thanks!
3 years, 10 months ago (2017-02-23 06:16:04 UTC) #8
Mike West
LGTM!
3 years, 10 months ago (2017-02-23 07:33:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707023007/1
3 years, 10 months ago (2017-02-23 12:11:33 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 12:15:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99b1bb0927bf4837bccbe01498b7...

Powered by Google App Engine
This is Rietveld 408576698