Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2708923011: Avoid duplicating the CSS property mapping for SVG pres. attrs. (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicating the CSS property mapping for SVG pres. attrs. The attribute (object) -> CSS property mapping is specified at construction and stored, so rather than having to repeat it, just read and use the stored value. Also add a cssValue() helper method to SVGAnimatedPath. Review-Url: https://codereview.chromium.org/2708923011 Cr-Commit-Position: refs/heads/master@{#452839} Committed: https://chromium.googlesource.com/chromium/src/+/2c4fd527db90b99fabaf9008216c95a6db521c58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -40 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimatedPath.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedPath.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMaskElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 10 months ago (2017-02-24 14:05:46 UTC) #7
Stephen Chennney
On 2017/02/24 14:05:46, fs wrote: lgtm
3 years, 10 months ago (2017-02-24 16:03:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708923011/1
3 years, 10 months ago (2017-02-24 16:07:18 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:20:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c4fd527db90b99fabaf9008216c...

Powered by Google App Engine
This is Rietveld 408576698