Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGImageElement.cpp

Issue 2708923011: Avoid duplicating the CSS property mapping for SVG pres. attrs. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org> 4 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 84
85 return true; 85 return true;
86 } 86 }
87 87
88 void SVGImageElement::collectStyleForPresentationAttribute( 88 void SVGImageElement::collectStyleForPresentationAttribute(
89 const QualifiedName& name, 89 const QualifiedName& name,
90 const AtomicString& value, 90 const AtomicString& value,
91 MutableStylePropertySet* style) { 91 MutableStylePropertySet* style) {
92 SVGAnimatedPropertyBase* property = propertyFromAttribute(name); 92 SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
93 if (property == m_width) { 93 if (property == m_width) {
94 addPropertyToPresentationAttributeStyle(style, CSSPropertyWidth, 94 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
95 m_width->cssValue()); 95 m_width->cssValue());
96 } else if (property == m_height) { 96 } else if (property == m_height) {
97 addPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, 97 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
98 m_height->cssValue()); 98 m_height->cssValue());
99 } else if (property == m_x) { 99 } else if (property == m_x) {
100 addPropertyToPresentationAttributeStyle(style, CSSPropertyX, 100 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
101 m_x->cssValue()); 101 m_x->cssValue());
102 } else if (property == m_y) { 102 } else if (property == m_y) {
103 addPropertyToPresentationAttributeStyle(style, CSSPropertyY, 103 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
104 m_y->cssValue()); 104 m_y->cssValue());
105 } else { 105 } else {
106 SVGGraphicsElement::collectStyleForPresentationAttribute(name, value, 106 SVGGraphicsElement::collectStyleForPresentationAttribute(name, value,
107 style); 107 style);
108 } 108 }
109 } 109 }
110 110
111 void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName) { 111 void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName) {
112 bool isLengthAttribute = 112 bool isLengthAttribute =
113 attrName == SVGNames::xAttr || attrName == SVGNames::yAttr || 113 attrName == SVGNames::xAttr || attrName == SVGNames::yAttr ||
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 const AtomicString SVGImageElement::imageSourceURL() const { 198 const AtomicString SVGImageElement::imageSourceURL() const {
199 return AtomicString(hrefString()); 199 return AtomicString(hrefString());
200 } 200 }
201 201
202 void SVGImageElement::didMoveToNewDocument(Document& oldDocument) { 202 void SVGImageElement::didMoveToNewDocument(Document& oldDocument) {
203 imageLoader().elementDidMoveToNewDocument(); 203 imageLoader().elementDidMoveToNewDocument();
204 SVGGraphicsElement::didMoveToNewDocument(oldDocument); 204 SVGGraphicsElement::didMoveToNewDocument(oldDocument);
205 } 205 }
206 206
207 } // namespace blink 207 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGMaskElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698