Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGCircleElement.cpp

Issue 2708923011: Avoid duplicating the CSS property mapping for SVG pres. attrs. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 76
77 return path; 77 return path;
78 } 78 }
79 79
80 void SVGCircleElement::collectStyleForPresentationAttribute( 80 void SVGCircleElement::collectStyleForPresentationAttribute(
81 const QualifiedName& name, 81 const QualifiedName& name,
82 const AtomicString& value, 82 const AtomicString& value,
83 MutableStylePropertySet* style) { 83 MutableStylePropertySet* style) {
84 SVGAnimatedPropertyBase* property = propertyFromAttribute(name); 84 SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
85 if (property == m_cx) { 85 if (property == m_cx) {
86 addPropertyToPresentationAttributeStyle(style, CSSPropertyCx, 86 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
87 m_cx->cssValue()); 87 m_cx->cssValue());
88 } else if (property == m_cy) { 88 } else if (property == m_cy) {
89 addPropertyToPresentationAttributeStyle(style, CSSPropertyCy, 89 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
90 m_cy->cssValue()); 90 m_cy->cssValue());
91 } else if (property == m_r) { 91 } else if (property == m_r) {
92 addPropertyToPresentationAttributeStyle(style, CSSPropertyR, 92 addPropertyToPresentationAttributeStyle(style, property->cssPropertyId(),
93 m_r->cssValue()); 93 m_r->cssValue());
94 } else { 94 } else {
95 SVGGeometryElement::collectStyleForPresentationAttribute(name, value, 95 SVGGeometryElement::collectStyleForPresentationAttribute(name, value,
96 style); 96 style);
97 } 97 }
98 } 98 }
99 99
100 void SVGCircleElement::svgAttributeChanged(const QualifiedName& attrName) { 100 void SVGCircleElement::svgAttributeChanged(const QualifiedName& attrName) {
101 if (attrName == SVGNames::rAttr || attrName == SVGNames::cxAttr || 101 if (attrName == SVGNames::rAttr || attrName == SVGNames::cxAttr ||
102 attrName == SVGNames::cyAttr) { 102 attrName == SVGNames::cyAttr) {
(...skipping 20 matching lines...) Expand all
123 return m_cx->currentValue()->isRelative() || 123 return m_cx->currentValue()->isRelative() ||
124 m_cy->currentValue()->isRelative() || 124 m_cy->currentValue()->isRelative() ||
125 m_r->currentValue()->isRelative(); 125 m_r->currentValue()->isRelative();
126 } 126 }
127 127
128 LayoutObject* SVGCircleElement::createLayoutObject(const ComputedStyle&) { 128 LayoutObject* SVGCircleElement::createLayoutObject(const ComputedStyle&) {
129 return new LayoutSVGEllipse(this); 129 return new LayoutSVGEllipse(this);
130 } 130 }
131 131
132 } // namespace blink 132 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedPath.cpp ('k') | third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698