Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2708113002: Revert of Add field_specs to all metrics in luci-py (Closed)

Created:
3 years, 10 months ago by M-A Ruel
Modified:
3 years, 10 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Revert of Add field_specs to all metrics in luci-py (patchset #2 id:20001 of https://codereview.chromium.org/2709453002/ ) Reason for revert: Reverting because rolling this version would break the instances. Original issue's description: > Roll infra_libs and gae_ts_mon in luci-py, and add field_specs to all metrics > > BUG=684974 > > Review-Url: https://codereview.chromium.org/2709453002 > Committed: https://github.com/luci/luci-py/commit/9ba306ed3b72c50f41f7a16e94e744b07bb46dc4 TBR=vadimsh@chromium.org,sergeyberezin@chromium.org,dsansome@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684974 Review-Url: https://codereview.chromium.org/2708113002 Committed: https://github.com/luci/luci-py/commit/f608998325f9c7eca8a7b418b2ea71fab36d07e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -659 lines) Patch
M appengine/gce-backend/metrics.py View 1 chunk +2 lines, -4 lines 0 comments Download
M appengine/machine_provider/metrics.py View 1 chunk +10 lines, -10 lines 0 comments Download
M appengine/swarming/ts_mon_metrics.py View 9 chunks +13 lines, -55 lines 0 comments Download
M appengine/third_party/gae_ts_mon/README.md View 2 chunks +3 lines, -6 lines 0 comments Download
M appengine/third_party/gae_ts_mon/__init__.py View 1 chunk +1 line, -4 lines 0 comments Download
M appengine/third_party/gae_ts_mon/config.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/third_party/gae_ts_mon/shared.py View 1 chunk +5 lines, -8 lines 0 comments Download
M client/third_party/infra_libs/event_mon/protos/goma_stats_pb2.py View 26 chunks +45 lines, -158 lines 0 comments Download
M client/third_party/infra_libs/httplib2_utils.py View 4 chunks +0 lines, -82 lines 0 comments Download
M client/third_party/infra_libs/logs/logs.py View 1 chunk +4 lines, -6 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/__init__.py View 1 chunk +1 line, -4 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/errors.py View 1 chunk +0 lines, -17 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/http_metrics.py View 1 chunk +11 lines, -39 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/interface.py View 3 chunks +26 lines, -8 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/metrics.py View 17 chunks +130 lines, -153 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/monitors.py View 6 chunks +39 lines, -80 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/standard_metrics.py View 1 chunk +1 line, -2 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/config.py View 1 chunk +3 lines, -4 lines 0 comments Download
M client/third_party/infra_libs/utils.py View 1 chunk +5 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
M-A Ruel
Created Revert of Add field_specs to all metrics in luci-py
3 years, 10 months ago (2017-02-21 14:38:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708113002/1
3 years, 10 months ago (2017-02-21 14:38:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/f608998325f9c7eca8a7b418b2ea71fab36d07e8
3 years, 10 months ago (2017-02-21 14:39:02 UTC) #6
Sergey Berezin
LGTM :-( What actually broke, and how can we fix it?
3 years, 10 months ago (2017-02-24 01:03:41 UTC) #7
M-A Ruel
On 2017/02/24 01:03:41, Sergey Berezin wrote: > LGTM :-( > > What actually broke, and ...
3 years, 10 months ago (2017-02-24 01:17:33 UTC) #8
Sergey Berezin
3 years, 10 months ago (2017-02-24 01:34:50 UTC) #9
Message was sent while issue was closed.
On 2017/02/24 at 01:17:33, maruel wrote:
> You can revert the revert now, asts_mon is fully integrated into bot_main.

Oh, OK, thanks! I'll let Dave do it though (EOW for me here...)

Powered by Google App Engine
This is Rietveld 408576698