Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3059)

Unified Diff: appengine/swarming/ts_mon_metrics.py

Issue 2708113002: Revert of Add field_specs to all metrics in luci-py (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/machine_provider/metrics.py ('k') | appengine/third_party/gae_ts_mon/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/ts_mon_metrics.py
diff --git a/appengine/swarming/ts_mon_metrics.py b/appengine/swarming/ts_mon_metrics.py
index 91cddbd8762b3b9a3b7d61069702f1668b73223d..4b80563e0b2c3e1f6e159951dd12951528368c5c 100644
--- a/appengine/swarming/ts_mon_metrics.py
+++ b/appengine/swarming/ts_mon_metrics.py
@@ -37,7 +37,7 @@
# A custom bucketer with 12% resolution in the range of 1..10**5.
# Used for job cycle times.
_bucketer = gae_ts_mon.GeometricBucketer(growth_factor=10**0.05,
- num_finite_buckets=100)
+ num_finite_buckets=100)
# Regular (instance-local) metrics: jobs/completed and jobs/durations.
# Both have the following metric fields:
@@ -48,23 +48,12 @@
# - result: one of 'success', 'failure', or 'infra-failure'.
jobs_completed = gae_ts_mon.CounterMetric(
'jobs/completed',
- 'Number of completed jobs.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.StringField('result'),
- ])
+ description='Number of completed jobs.')
jobs_durations = gae_ts_mon.CumulativeDistributionMetric(
- 'jobs/durations',
- 'Cycle times of completed jobs, in seconds.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.StringField('result'),
- ],
- bucketer=_bucketer)
+ 'jobs/durations', bucketer=_bucketer,
+ description='Cycle times of completed jobs, in seconds.')
# Similar to jobs/completed and jobs/duration, but with a dedup field.
@@ -75,12 +64,7 @@
# - deduped: boolean describing whether the job was deduped or not.
jobs_requested = gae_ts_mon.CounterMetric(
'jobs/requested',
- 'Number of requested jobs over time.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.BooleanField('deduped'),
- ])
+ description='Number of requested jobs over time.')
# Swarming-specific metric. Metric fields:
@@ -90,11 +74,7 @@
# for buildbot jobs.
tasks_expired = gae_ts_mon.CounterMetric(
'swarming/tasks/expired',
- 'Number of expired tasks', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- ])
+ description='Number of expired tasks')
# Global metric. Metric fields:
# - project_id: e.g. 'chromium'
@@ -108,11 +88,7 @@
# send this metric.
jobs_running = gae_ts_mon.BooleanMetric(
'jobs/running',
- 'Presence metric for a running job.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- ])
+ description='Presence metric for a running job.')
# Global metric. Metric fields:
# - project_id: e.g. 'chromium'
@@ -122,19 +98,13 @@
# - status: 'pending' or 'running'.
jobs_active = gae_ts_mon.GaugeMetric(
'jobs/active',
- 'Number of running, pending or otherwise active jobs.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.StringField('status'),
- ])
+ description='Number of running, pending or otherwise active jobs.')
# Global metric. Target field: hostname = 'autogen:<executor_id>' (bot id).
executors_pool = gae_ts_mon.StringMetric(
'executors/pool',
- 'Pool name for a given job executor.',
- None)
+ description='Pool name for a given job executor.')
# Global metric. Target fields:
@@ -144,8 +114,7 @@
# 'dead'.
executors_status = gae_ts_mon.StringMetric(
'executors/status',
- 'Status of a job executor.',
- None)
+ description=('Status of a job executor.'))
# Global metric. Target fields:
@@ -156,14 +125,8 @@
# Note that 'running' will report data as long as the job is running,
# so it is best to restrict data to status == 'pending.'
jobs_pending_durations = gae_ts_mon.NonCumulativeDistributionMetric(
- 'jobs/pending_durations',
- 'Pending times of active jobs, in seconds.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.StringField('status'),
- ],
- bucketer=_bucketer)
+ 'jobs/pending_durations', bucketer=_bucketer,
+ description='Pending times of active jobs, in seconds.')
# Global metric. Target fields:
@@ -175,12 +138,7 @@
# so it is best to restrict data to status == 'pending.'
jobs_max_pending_duration = gae_ts_mon.FloatMetric(
'jobs/max_pending_duration',
- 'Maximum pending seconds of pending jobs.', [
- gae_ts_mon.StringField('spec_name'),
- gae_ts_mon.StringField('project_id'),
- gae_ts_mon.StringField('subproject_id'),
- gae_ts_mon.StringField('status'),
- ])
+ description='Maximum pending seconds of pending jobs.')
def pool_from_dimensions(dimensions):
« no previous file with comments | « appengine/machine_provider/metrics.py ('k') | appengine/third_party/gae_ts_mon/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698