Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2709453002: Add field_specs to all metrics in luci-py (Closed)

Created:
3 years, 10 months ago by dsansome
Modified:
3 years, 10 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Roll infra_libs and gae_ts_mon in luci-py, and add field_specs to all metrics BUG=684974 Review-Url: https://codereview.chromium.org/2709453002 Committed: https://github.com/luci/luci-py/commit/9ba306ed3b72c50f41f7a16e94e744b07bb46dc4

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -282 lines) Patch
M appengine/gce-backend/metrics.py View 1 chunk +4 lines, -2 lines 0 comments Download
M appengine/machine_provider/metrics.py View 1 chunk +10 lines, -10 lines 0 comments Download
M appengine/swarming/ts_mon_metrics.py View 1 9 chunks +55 lines, -13 lines 0 comments Download
M appengine/third_party/gae_ts_mon/README.md View 2 chunks +6 lines, -3 lines 0 comments Download
M appengine/third_party/gae_ts_mon/__init__.py View 1 chunk +4 lines, -1 line 0 comments Download
M appengine/third_party/gae_ts_mon/config.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/third_party/gae_ts_mon/shared.py View 1 chunk +8 lines, -5 lines 0 comments Download
M client/third_party/infra_libs/event_mon/protos/goma_stats_pb2.py View 26 chunks +158 lines, -45 lines 0 comments Download
M client/third_party/infra_libs/httplib2_utils.py View 4 chunks +82 lines, -0 lines 0 comments Download
M client/third_party/infra_libs/logs/logs.py View 1 chunk +5 lines, -3 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/__init__.py View 1 chunk +4 lines, -1 line 0 comments Download
M client/third_party/infra_libs/ts_mon/common/errors.py View 1 chunk +17 lines, -0 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/http_metrics.py View 1 chunk +39 lines, -11 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/interface.py View 3 chunks +8 lines, -26 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/metrics.py View 17 chunks +138 lines, -115 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/monitors.py View 6 chunks +78 lines, -37 lines 0 comments Download
M client/third_party/infra_libs/ts_mon/common/standard_metrics.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/third_party/infra_libs/ts_mon/config.py View 1 chunk +4 lines, -3 lines 0 comments Download
M client/third_party/infra_libs/utils.py View 1 chunk +18 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsansome
3 years, 10 months ago (2017-02-20 06:06:50 UTC) #3
Vadim Sh.
lgtm
3 years, 10 months ago (2017-02-20 20:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709453002/20001
3 years, 10 months ago (2017-02-20 23:25:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/9ba306ed3b72c50f41f7a16e94e744b07bb46dc4
3 years, 10 months ago (2017-02-21 00:00:29 UTC) #9
M-A Ruel
3 years, 10 months ago (2017-02-21 14:38:38 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2708113002/ by maruel@chromium.org.

The reason for reverting is: Reverting because rolling this version would break
the instances..

Powered by Google App Engine
This is Rietveld 408576698