Web Share (desktop): DCHECK instead of user error for invalid URLs.

Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=694380
Review-Url: https://codereview.chromium.org/2708023002
Cr-Commit-Position: refs/heads/master@{#451713}
Committed: https://chromium.googlesource.com/chromium/src/+/f3a4c639191b2bd7b43581550b970e50d0f188d0

[Matt Giuca, 2017-02-21 03:03:54]

mgiuca@chromium.org changed reviewers:
+ sammc@chromium.org

[Matt Giuca, 2017-02-21 04:12:51]

Description was changed from

==========
ShareServiceImplUnittest: Added two new tests for error conditions.

BUG=668389
==========

to

==========
Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=668389
==========

[Matt Giuca, 2017-02-21 04:13:00]

Description was changed from

==========
Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=668389
==========

to

==========
Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=694380
==========

[Matt Giuca, 2017-02-21 04:15:01]

PTAL; now does a DCHECK instead of failing is_valid.

I'm still on the fence about this; the argument that the URL can't be made
invalid by the user relies on a hell of a lot of code (e.g., I tried setting
"\u0000" in the manifest and it was valid, only because somewhere along the line
that NUL character got filtered out).

But I figure we'll eventually do a validity check in the manifest parse so this
should be a DCHECK long term anyway.

[Sam McNally, 2017-02-21 06:44:24]

lgtm

[Matt Giuca, 2017-02-21 07:17:19]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-02-21 07:17:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 08:09:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487661439933130,
"parent_rev": "88916b8ccc7a34369f8dbe77e71afb4831425df5", "commit_rev":
"f3a4c639191b2bd7b43581550b970e50d0f188d0"}

[commit-bot: I haz the power, 2017-02-21 08:09:43]

Description was changed from

==========
Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=694380
==========

to

==========
Web Share (desktop): DCHECK instead of user error for invalid URLs.

We couldn't find any way to trigger this in practice (even though
certain inputs to ShareServiceImpl can cause it).

Also adds a new test for an invalid URL template.

BUG=694380

Review-Url: https://codereview.chromium.org/2708023002
Cr-Commit-Position: refs/heads/master@{#451713}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3a4c639191b2bd7b43581550b97...
==========

[commit-bot: I haz the power, 2017-02-21 08:09:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f3a4c639191b2bd7b43581550b97...