Web Share (desktop): DCHECK instead of user error for invalid URLs.

chrome/browser/webshare/share_service_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 237 matching lines @@
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlHigh)),
       make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlLow))};
   EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
 
   // Cancel the dialog.
   share_service_helper()->picker_callback().Run(base::nullopt);
 
   EXPECT_TRUE(share_service_helper()->GetLastUsedTargetURL().empty());
 }
 
+// Tests a target with a broken URL template (ReplacePlaceholders failure).
+TEST_F(ShareServiceImplUnittest, ShareBrokenUrl) {
+  // Invalid placeholders. Detailed tests for broken templates are in the
+  // ReplacePlaceholders test; this just tests the share response.
+  constexpr char kBrokenUrlTemplate[] = "share?title={title";
+  share_service_helper()->AddShareTargetToPrefs(kManifestUrlHigh, kTargetName,
+                                                kBrokenUrlTemplate);
+
+  // Expect an error message in response.
+  base::Callback<void(const base::Optional<std::string>&)> callback =
+      base::Bind(&DidShare,
+                 base::Optional<std::string>(
+                     "Error: unable to replace placeholders in url template"));
+
+  base::RunLoop run_loop;
+  share_service_helper()->set_run_loop(&run_loop);
+
+  const GURL url(kUrlSpec);
+  share_service()->Share(kTitle, kText, url, callback);
+
+  run_loop.Run();
+
+  const std::vector<std::pair<base::string16, GURL>> kExpectedTargets{
+      make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlHigh))};
+  EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
+
+  // Pick example-high.com.
+  share_service_helper()->picker_callback().Run(
+      base::Optional<std::string>(kManifestUrlHigh));
+
+  EXPECT_TRUE(share_service_helper()->GetLastUsedTargetURL().empty());
+}
+
 // Test to check that only targets with enough engagement were in picker.
 TEST_F(ShareServiceImplUnittest, ShareWithSomeInsufficientlyEngagedTargets) {
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlMin, kTargetName,
                                                 kUrlTemplate);
   share_service_helper()->AddShareTargetToPrefs(kManifestUrlLow, kTargetName,
                                                 kUrlTemplate);
 
   base::Callback<void(const base::Optional<std::string>&)> callback =
       base::Bind(&DidShare, base::Optional<std::string>());
 
@@ skipping 249 matching lines @@
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%C3%A9", url_template_filled);
 
   // U+1F4A9
   url_template = "{title}";
   succeeded = ShareServiceImpl::ReplacePlaceholders(
       url_template, "\xf0\x9f\x92\xa9", kText, url, &url_template_filled);
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%F0%9F%92%A9", url_template_filled);
 }