Web Share: Refactor Mojo interface to now return an enum error.

Web Share: Refactor Mojo interface to now return an enum error.

Previously returned a string containing the error message, which was a
source of inconsistency among the different platforms. Now all platforms
generate the same error messages for the user, and those are done in a
centralized place.

BUG=687376
Review-Url: https://codereview.chromium.org/2703333002
Cr-Commit-Position: refs/heads/master@{#454485}
Committed: https://chromium.googlesource.com/chromium/src/+/17e725cb4b30de97279784130bdb36b8a3162a26

[Matt Giuca, 2017-02-21 05:15:31]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 05:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2017-02-21 05:36:43]

mgiuca@chromium.org changed reviewers:
+ sammc@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:08:24]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2017-02-21 23:02:40]

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
(right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js:3: let
ShareError;
This is ugly. Consider passing webshare into the share_test function instead.

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:73: //
TODO(mgiuca): Work out which error type to use.
Maybe it's time for this?

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/webshare/webshare.mojom (right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/webshare/webshare.mojom:21:
INVALID_TEMPLATE,
With the impending removal of this error, can we skip straight to not having it
and use INTERNAL_ERROR instead?

[Matt Giuca, 2017-02-23 04:18:37]

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
(right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js:3: let
ShareError;
On 2017/02/21 23:02:40, Sam McNally wrote:
> This is ugly. Consider passing webshare into the share_test function instead.

Done.

(I find that uglier... but whatever.)

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:73: //
TODO(mgiuca): Work out which error type to use.
On 2017/02/21 23:02:40, Sam McNally wrote:
> Maybe it's time for this?

Hmm, it's kind of a spec issue. What types would you use?

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/webshare/webshare.mojom (right):

https://codereview.chromium.org/2703333002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/webshare/webshare.mojom:21:
INVALID_TEMPLATE,
On 2017/02/21 23:02:40, Sam McNally wrote:
> With the impending removal of this error, can we skip straight to not having
it
> and use INTERNAL_ERROR instead?

Done.

[Sam McNally, 2017-02-23 22:37:41]

lgtm

[Matt Giuca, 2017-02-23 22:59:01]

mgiuca@chromium.org changed reviewers:
+ dtrainor@chromium.org, rsesek@chromium.org

[Matt Giuca, 2017-02-23 22:59:01]

dtrainor: for ShareServiceImpl.java.
rsesek: for IPC security owners.

Thanks!

[Robert Sesek, 2017-02-23 23:09:39]

mojom lgtm

[David Trainor- moved to gerrit, 2017-02-28 01:13:44]

lgtm

[Matt Giuca, 2017-02-28 01:23:59]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:24:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 03:55:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2017-03-02 04:08:44]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-03-02 04:08:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sammc@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2703333002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-02 04:09:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 05:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 05:53:04]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2017-03-02 23:05:48]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-03-02 23:05:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sammc@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2703333002/#ps60001
(title: "Fix assignment statement. #oops")

[commit-bot: I haz the power, 2017-03-02 23:06:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 02:57:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488495948898880,
"parent_rev": "9c2c178bf2d446aefeb2b7a24c7cf55856e10b0d", "commit_rev":
"17e725cb4b30de97279784130bdb36b8a3162a26"}

[commit-bot: I haz the power, 2017-03-03 02:58:07]

Description was changed from

==========
Web Share: Refactor Mojo interface to now return an enum error.

Previously returned a string containing the error message, which was a
source of inconsistency among the different platforms. Now all platforms
generate the same error messages for the user, and those are done in a
centralized place.

BUG=687376
==========

to

==========
Web Share: Refactor Mojo interface to now return an enum error.

Previously returned a string containing the error message, which was a
source of inconsistency among the different platforms. Now all platforms
generate the same error messages for the user, and those are done in a
centralized place.

BUG=687376

Review-Url: https://codereview.chromium.org/2703333002
Cr-Commit-Position: refs/heads/master@{#454485}
Committed:
https://chromium.googlesource.com/chromium/src/+/17e725cb4b30de97279784130bdb...
==========

[commit-bot: I haz the power, 2017-03-03 02:58:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/17e725cb4b30de97279784130bdb...