Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2707133005: Remove a regression test that depended on utils.ImportNow() (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove a regression test that depended on utils.ImportNow() The test itself was for an issue that's handled statically since https://codereview.chromium.org/1302313013 (we were missing some instance types in a switch statement). This leaves us with only a single test that depends on the JS native import system. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2707133005 Cr-Commit-Position: refs/heads/master@{#43393} Committed: https://chromium.googlesource.com/v8/v8/+/184e80a60d95deee5b5b5390d3672aafb6b7da3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/js/prologue.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regress/regress-3281.js View 1 chunk +0 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
adamk
3 years, 10 months ago (2017-02-22 22:47:58 UTC) #1
Yang
On 2017/02/22 22:47:58, adamk wrote: lgtm
3 years, 10 months ago (2017-02-23 06:07:19 UTC) #2
Dan Ehrenberg
lgtm Seems reasonable, since the SetIterator constructor is not accessible from JS and we have ...
3 years, 10 months ago (2017-02-23 10:44:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707133005/1
3 years, 10 months ago (2017-02-23 17:05:18 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:31:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/184e80a60d95deee5b5b5390d3672aafb6b...

Powered by Google App Engine
This is Rietveld 408576698