Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2711833002: Remove tiny unit test for MinSimple/MaxSimple (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove tiny unit test for MinSimple/MaxSimple The source code of those functions is simple a ternary operator, and the test seems to have been designed as a "regression" test for the previous implementation (which used a macro, and thus evaluated its arguments multiple times). I don't think the test is worth the weight of supporting importing JS natives from tests. This patch removes the last test that depends on JS natives. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2711833002 Cr-Commit-Position: refs/heads/master@{#43394} Committed: https://chromium.googlesource.com/v8/v8/+/837760ecb7ff2ccaf7921ab46e7b473b313d4a4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M src/js/prologue.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/minmax-simple.js View 1 chunk +0 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
adamk
3 years, 10 months ago (2017-02-22 22:52:05 UTC) #1
Yang
On 2017/02/22 22:52:05, adamk wrote: lgtm
3 years, 10 months ago (2017-02-23 06:07:57 UTC) #4
Dan Ehrenberg
lgtm
3 years, 10 months ago (2017-02-23 10:32:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711833002/1
3 years, 10 months ago (2017-02-23 17:49:40 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 18:19:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/837760ecb7ff2ccaf7921ab46e7b473b313...

Powered by Google App Engine
This is Rietveld 408576698