Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1302313013: Handle all InstanceTypes in BitsetType::Lub(). (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handle all InstanceTypes in BitsetType::Lub(). JS_ITERATOR_RESULT_TYPE was missing but required (repro: load inbox.google.com with a Debug build). R=bmeurer@chromium.org Committed: https://crrev.com/082730a440c415e926d2fcce0ae800c0fea5e92b Cr-Commit-Position: refs/heads/master@{#30586}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/types.cc View 4 chunks +37 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/1302313013/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/1302313013/diff/1/src/types.cc#newcode293 src/types.cc:293: case FIXED_##TYPE##_ARRAY_TYPE: clang-format insists on this indentation :-/
5 years, 3 months ago (2015-09-04 11:19:11 UTC) #1
Benedikt Meurer
Nice, thanks for fixing. LGTM!
5 years, 3 months ago (2015-09-04 11:19:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302313013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302313013/1
5 years, 3 months ago (2015-09-04 11:21:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 11:46:47 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 11:47:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/082730a440c415e926d2fcce0ae800c0fea5e92b
Cr-Commit-Position: refs/heads/master@{#30586}

Powered by Google App Engine
This is Rietveld 408576698