Verify that clearing browsing data clears permission embargo.

chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
 
 #include "base/guid.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/scoped_feature_list.h"
 #include "base/time/time.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_impl.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/domain_reliability/service_factory.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/permissions/permission_decision_auto_blocker.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/storage/durable_storage_permission_context.h"
 #include "chrome/browser/translate/language_model_factory.h"
+#include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/personal_data_manager_observer.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/bookmarks/browser/bookmark_model.h"
@@ skipping 523 matching lines @@
   }
 
   int GetIgnoreCount(const GURL& url, ContentSettingsType permission) {
     return autoblocker_->GetIgnoreCount(url, permission);
   }
 
   int RecordIgnore(const GURL& url, ContentSettingsType permission) {
     return autoblocker_->RecordIgnore(url, permission);
   }
 
-  bool ShouldChangeDismissalToBlock(const GURL& url,
-                                    ContentSettingsType permission) {
+  bool RecordDismissAndEmbargo(const GURL& url,
+                               ContentSettingsType permission) {
     return autoblocker_->RecordDismissAndEmbargo(url, permission);
   }
 
+  void CheckEmbargo(const GURL& url,
+                    ContentSettingsType permission,
+                    ContentSetting expected_setting) {
+    EXPECT_EQ(expected_setting,
+              autoblocker_->GetEmbargoResult(permission, url).content_setting);
+  }
+
  private:
   PermissionDecisionAutoBlocker* autoblocker_;
 
   DISALLOW_COPY_AND_ASSIGN(RemovePermissionPromptCountsTest);
 };
 
 #if BUILDFLAG(ENABLE_PLUGINS)
 // A small modification to MockBrowsingDataFlashLSOHelper so that it responds
 // immediately and does not wait for the Notify() call. Otherwise it would
 // deadlock BrowsingDataRemoverImpl::RemoveImpl.
@@ skipping 976 matching lines @@
 TEST_F(ChromeBrowsingDataRemoverDelegateTest, ClearPermissionPromptCounts) {
   RemovePermissionPromptCountsTest tester(GetProfile());
 
   std::unique_ptr<BrowsingDataFilterBuilder> filter_builder_1(
       BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::WHITELIST));
   filter_builder_1->AddRegisterableDomain(kTestRegisterableDomain1);
 
   std::unique_ptr<BrowsingDataFilterBuilder> filter_builder_2(
       BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::BLACKLIST));
   filter_builder_2->AddRegisterableDomain(kTestRegisterableDomain1);
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitWithFeatures({features::kBlockPromptsIfDismissedOften}, {});
 
   {
     // Test REMOVE_HISTORY.
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(2, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
-    tester.ShouldChangeDismissalToBlock(kOrigin1,
-                                        CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin2,
                                      CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
-    tester.ShouldChangeDismissalToBlock(kOrigin2,
-                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
+    tester.CheckEmbargo(kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                        CONTENT_SETTING_ASK);
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    EXPECT_TRUE(tester.RecordDismissAndEmbargo(
+        kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    tester.CheckEmbargo(kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                        CONTENT_SETTING_BLOCK);
 
     BlockUntilOriginDataRemoved(AnHourAgo(), base::Time::Max(),
                                 BrowsingDataRemover::REMOVE_SITE_USAGE_DATA,
                                 std::move(filter_builder_1));
 
     // kOrigin1 should be gone, but kOrigin2 remains.
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
     EXPECT_EQ(0, tester.GetDismissCount(kOrigin1,
                                         CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
     EXPECT_EQ(1, tester.GetIgnoreCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
-    EXPECT_EQ(1, tester.GetDismissCount(
-                     kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    EXPECT_EQ(3, tester.GetDismissCount(kOrigin2,
+                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    tester.CheckEmbargo(kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                        CONTENT_SETTING_BLOCK);
 
     BlockUntilBrowsingDataRemoved(AnHourAgo(), base::Time::Max(),
                                   BrowsingDataRemover::REMOVE_HISTORY, false);
 
     // Everything should be gone.
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
     EXPECT_EQ(0, tester.GetDismissCount(kOrigin1,
                                         CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
     EXPECT_EQ(0, tester.GetIgnoreCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
     EXPECT_EQ(0, tester.GetDismissCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    tester.CheckEmbargo(kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
+                        CONTENT_SETTING_ASK);
   }
   {
     // Test REMOVE_SITE_DATA.
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(2, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin1,
                                      CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
-    tester.ShouldChangeDismissalToBlock(kOrigin1,
-                                        CONTENT_SETTINGS_TYPE_MIDI_SYSEX);
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
+    tester.CheckEmbargo(kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+                        CONTENT_SETTING_ASK);
     EXPECT_EQ(1, tester.RecordIgnore(kOrigin2,
                                      CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
-    tester.ShouldChangeDismissalToBlock(kOrigin2,
-                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
 
     BlockUntilOriginDataRemoved(AnHourAgo(), base::Time::Max(),
                                 BrowsingDataRemover::REMOVE_SITE_USAGE_DATA,
                                 std::move(filter_builder_2));
 
     // kOrigin2 should be gone, but kOrigin1 remains.
     EXPECT_EQ(2, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(1, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
     EXPECT_EQ(1, tester.GetDismissCount(kOrigin1,
                                         CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
     EXPECT_EQ(0, tester.GetIgnoreCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
     EXPECT_EQ(0, tester.GetDismissCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
 
+    EXPECT_FALSE(tester.RecordDismissAndEmbargo(
+        kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
+    EXPECT_TRUE(tester.RecordDismissAndEmbargo(
+        kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
+    EXPECT_EQ(
+        3, tester.GetDismissCount(kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
+    tester.CheckEmbargo(kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+                        CONTENT_SETTING_BLOCK);
+
     BlockUntilBrowsingDataRemoved(AnHourAgo(), base::Time::Max(),
                                   BrowsingDataRemover::REMOVE_SITE_USAGE_DATA,
                                   false);
 
     // Everything should be gone.
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_GEOLOCATION));
     EXPECT_EQ(0, tester.GetIgnoreCount(kOrigin1,
                                        CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
     EXPECT_EQ(0, tester.GetDismissCount(kOrigin1,
                                         CONTENT_SETTINGS_TYPE_MIDI_SYSEX));
     EXPECT_EQ(0, tester.GetIgnoreCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_DURABLE_STORAGE));
     EXPECT_EQ(0, tester.GetDismissCount(
                      kOrigin2, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
+    tester.CheckEmbargo(kOrigin1, CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
+                        CONTENT_SETTING_ASK);
   }
 }
 
 #if BUILDFLAG(ENABLE_PLUGINS)
 TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemovePluginData) {
   RemovePluginDataTester tester(GetProfile());
 
   tester.AddDomain(kOrigin1.host());
   tester.AddDomain(kOrigin2.host());
   tester.AddDomain(kOrigin3.host());
@@ skipping 108 matching lines @@
   EXPECT_THAT(language_model->GetLanguageFrequency("es"), FloatEq(0.25));
 
   // Clearing the full history does the trick.
   BlockUntilBrowsingDataRemoved(base::Time(), base::Time::Max(),
                                 BrowsingDataRemover::REMOVE_HISTORY, false);
 
   EXPECT_THAT(language_model->GetTopLanguages(), SizeIs(0));
   EXPECT_THAT(language_model->GetLanguageFrequency("en"), FloatEq(0.0));
   EXPECT_THAT(language_model->GetLanguageFrequency("es"), FloatEq(0.0));
 }