Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2706863002: Merge "[NTP::Downloads] Do not fetch Offline Pages when their model ..." (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge "[NTP::Downloads] Do not fetch Offline Pages when their model ..." This is a merge of https://codereview.chromium.org/2667073003 into M57 (branch 2987). This CL is needed in order to merge https://codereview.chromium.org/2683383002 (issue 690391) into the same branch. There were no conflicts, it has been tested on two devices + unittests. Original description: Previously we used to query Offline Pages model both in the constructor and when Offline Page model was loaded. However, after https://codereview.chromium.org/2536573003 if Offline Page model is not loaded, it waits and replies only after it has been loaded, so the fetch in the constructor is now sufficient. This CL removes the fetch from OfflinePageModelLoaded and related tests. BUG=669404 Review-Url: https://codereview.chromium.org/2667073003 Cr-Commit-Position: refs/heads/master@{#447743} (cherry picked from commit 64245189bdea8d0ee8496f76b3c4d278610274e9) Review-Url: https://codereview.chromium.org/2706863002 . Cr-Commit-Position: refs/branch-heads/2987@{#597} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 3 chunks +15 lines, -34 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vitaliii
3 years, 10 months ago (2017-02-20 15:20:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b.

Powered by Google App Engine
This is Rietveld 408576698