Chromium Code Reviews
DescriptionMerge "[NTP::Downloads] Do not fetch Offline Pages when their model ..."
This is a merge of https://codereview.chromium.org/2667073003 into M57
(branch 2987). This CL is needed in order to merge
https://codereview.chromium.org/2683383002 (issue 690391) into the same
branch.
There were no conflicts, it has been tested on two devices + unittests.
Original description:
Previously we used to query Offline Pages model both in the constructor
and when Offline Page model was loaded. However, after
https://codereview.chromium.org/2536573003 if Offline Page model is not
loaded, it waits and replies only after it has been loaded, so the fetch
in the constructor is now sufficient. This CL removes the fetch from
OfflinePageModelLoaded and related tests.
BUG=669404
Review-Url: https://codereview.chromium.org/2667073003
Cr-Commit-Position: refs/heads/master@{#447743}
(cherry picked from commit 64245189bdea8d0ee8496f76b3c4d278610274e9)
Review-Url: https://codereview.chromium.org/2706863002 .
Cr-Commit-Position: refs/branch-heads/2987@{#597}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/9cdefe6184da5cd4e23d47bd2df7f17cc6d4825b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||