[NTP::Downloads] Do not fetch Offline Pages when their model is loaded.

[NTP::Downloads] Do not fetch Offline Pages when their model is loaded.

Previously we used to query Offline Pages model both in the constructor
and when Offline Page model was loaded. However, after
https://codereview.chromium.org/2536573003 if Offline Page model is not
loaded, it waits and replies only after it has been loaded, so the fetch
in the constructor is now sufficient. This CL removes the fetch from
OfflinePageModelLoaded and related tests.

BUG=669404
Review-Url: https://codereview.chromium.org/2667073003
Cr-Commit-Position: refs/heads/master@{#447743}
Committed: https://chromium.googlesource.com/chromium/src/+/64245189bdea8d0ee8496f76b3c4d278610274e9

[vitaliii, 2017-02-01 15:21:48]

Patchset #1 (id:1) has been deleted

[vitaliii, 2017-02-01 15:21:54]

Patchset #1 (id:20001) has been deleted

[vitaliii, 2017-02-01 15:22:05]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 15:22:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2017-02-01 15:22:33]

vitaliii@chromium.org changed reviewers:
+ treib@chromium.org

[vitaliii, 2017-02-01 15:22:34]

Hi treib@,

Could you have a look?

[Marc Treib, 2017-02-01 16:37:31]

lgtm

https://codereview.chromium.org/2667073003/diff/40001/chrome/browser/ntp_snip...
File chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
(right):

https://codereview.chromium.org/2667073003/diff/40001/chrome/browser/ntp_snip...
chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc:827:
ShouldFetchOfflinePageDownloadsOnStartupButOnlyOnce) {
nit: I'd remove the "ButOnlyOnce". That should be the default assumption :)

[commit-bot: I haz the power, 2017-02-01 16:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:58:14]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vitaliii, 2017-02-02 11:09:07]

I addressed your nit, no need to look.

https://codereview.chromium.org/2667073003/diff/40001/chrome/browser/ntp_snip...
File chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
(right):

https://codereview.chromium.org/2667073003/diff/40001/chrome/browser/ntp_snip...
chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc:827:
ShouldFetchOfflinePageDownloadsOnStartupButOnlyOnce) {
On 2017/02/01 16:37:31, Marc Treib wrote:
> nit: I'd remove the "ButOnlyOnce". That should be the default assumption :)

Done.

[vitaliii, 2017-02-02 11:10:20]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2017-02-02 11:10:20]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2667073003/#ps80001
(title: "treib@ nit.")

[commit-bot: I haz the power, 2017-02-02 11:10:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 11:59:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486033820513390,
"parent_rev": "ec621b7c159caafad6ea2a0f47bb2d5d35d8ee31", "commit_rev":
"64245189bdea8d0ee8496f76b3c4d278610274e9"}

[commit-bot: I haz the power, 2017-02-02 12:00:26]

Description was changed from

==========
[NTP::Downloads] Do not fetch Offline Pages when their model is loaded.

Previously we used to query Offline Pages model both in the constructor
and when Offline Page model was loaded. However, after
https://codereview.chromium.org/2536573003 if Offline Page model is not
loaded, it waits and replies only after it has been loaded, so the fetch
in the constructor is now sufficient. This CL removes the fetch from
OfflinePageModelLoaded and related tests.

BUG=669404
==========

to

==========
[NTP::Downloads] Do not fetch Offline Pages when their model is loaded.

Previously we used to query Offline Pages model both in the constructor
and when Offline Page model was loaded. However, after
https://codereview.chromium.org/2536573003 if Offline Page model is not
loaded, it waits and replies only after it has been loaded, so the fetch
in the constructor is now sufficient. This CL removes the fetch from
OfflinePageModelLoaded and related tests.

BUG=669404

Review-Url: https://codereview.chromium.org/2667073003
Cr-Commit-Position: refs/heads/master@{#447743}
Committed:
https://chromium.googlesource.com/chromium/src/+/64245189bdea8d0ee8496f76b3c4...
==========

[commit-bot: I haz the power, 2017-02-02 12:00:27]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/64245189bdea8d0ee8496f76b3c4...