[Offline pages] Preventing GetPagesMatchingQuery from running before model is loaded

[Offline pages] Preventing GetPagesMatchingQuery from running before model is loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
Committed: https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484
Cr-Commit-Position: refs/heads/master@{#434726}

[fgorski, 2016-11-28 16:44:32]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 16:44:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-11-28 16:45:52]

Description was changed from

==========
[Offline pages] Preventing GetPagesMatchingQuery to run before model is loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
==========

to

==========
[Offline pages] Preventing GetPagesMatchingQuery from running before model is
loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
==========

[fgorski, 2016-11-28 16:47:28]

fgorski@chromium.org changed reviewers:
+ dewittj@chromium.org, vitaliii@chromium.org

[fgorski, 2016-11-28 16:47:28]

PTAL

[commit-bot: I haz the power, 2016-11-28 17:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 17:28:16]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-11-28 17:52:09]

Thanks for fixing my bug.  Mostly lg, just a preference to simplify things  a
little bit.

https://codereview.chromium.org/2536573003/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2536573003/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:492: RunWhenLoaded(
This could simply be rewritten as GetPagesMatchingQuery(...)

[fgorski, 2016-11-28 18:30:58]

https://codereview.chromium.org/2536573003/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2536573003/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:492: RunWhenLoaded(
On 2016/11/28 17:52:09, dewittj wrote:
> This could simply be rewritten as GetPagesMatchingQuery(...)

I know, but it sticks to the pattern applied in this file.

[dewittj, 2016-11-28 18:35:54]

I won't hold you up on this but it still feels like a bunch of duplicated code
to RunWhenLoaded all over the place.

lgtm

[fgorski, 2016-11-28 20:56:28]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:57:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:49:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480366588525460,
"parent_rev": "08a7de93eb9b0b9ac9d458390f97adc1957e743f", "commit_rev":
"6f6492ea5666f57e7d0c3d2b4a5c74a756b6a6b5"}

[commit-bot: I haz the power, 2016-11-28 21:50:03]

Description was changed from

==========
[Offline pages] Preventing GetPagesMatchingQuery from running before model is
loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
==========

to

==========
[Offline pages] Preventing GetPagesMatchingQuery from running before model is
loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
==========

[commit-bot: I haz the power, 2016-11-28 21:50:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 21:51:57]

Description was changed from

==========
[Offline pages] Preventing GetPagesMatchingQuery from running before model is
loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174
==========

to

==========
[Offline pages] Preventing GetPagesMatchingQuery from running before model is
loaded

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174

Committed: https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484
Cr-Commit-Position: refs/heads/master@{#434726}
==========

[commit-bot: I haz the power, 2016-11-28 21:51:58]

Patchset 2 (id:??) landed as
https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484
Cr-Commit-Position: refs/heads/master@{#434726}