Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2706063002: 📰 Make the section dismissal range dynamic (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Make the section dismissal range dynamic The section dismissal range used to be hardcoded, but since the header is now optional, it requires to shift it up. This change stops the hardcoding and just uses computed positions BUG=692978 Review-Url: https://codereview.chromium.org/2706063002 Cr-Commit-Position: refs/heads/master@{#451627} Committed: https://chromium.googlesource.com/chromium/src/+/2593372e3ff1af1415f0f53b19078b99e6709483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 10 months ago (2017-02-20 13:14:43 UTC) #2
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-20 14:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706063002/1
3 years, 10 months ago (2017-02-20 15:02:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 15:07:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2593372e3ff1af1415f0f53b1907...

Powered by Google App Engine
This is Rietveld 408576698