📰 Make the section dismissal range dynamic

chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.cards;
 
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.collection.IsIterableContainingInOrder.contains;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ skipping 100 matching lines @@
         // With snippets.
         section.setSuggestions(snippets, CategoryStatus.AVAILABLE, /* replaceExisting = */ true);
         assertEquals(ItemViewType.HEADER, section.getItemViewType(0));
         assertEquals(Collections.emptySet(), section.getItemDismissalGroup(0));
         assertEquals(ItemViewType.SNIPPET, section.getItemViewType(1));
         assertEquals(Collections.singleton(1), section.getItemDismissalGroup(1));
     }
 
     @Test
     @Feature({"Ntp"})
+    public void testGetDismissalGroupWithoutHeader() {
+        SuggestionsSection section = createSectionWithFetchAction(true);
+        section.setHeaderVisibility(false);
+
+        assertEquals(ItemViewType.STATUS, section.getItemViewType(0));
+        assertEquals(setOf(0, 1), section.getItemDismissalGroup(0));
+
+        assertEquals(ItemViewType.ACTION, section.getItemViewType(1));
+        assertEquals(setOf(0, 1), section.getItemDismissalGroup(1));
+    }
+
+    @Test
+    @Feature({"Ntp"})
+    public void testGetDismissalGroupWithoutAction() {
+        SuggestionsSection section = createSectionWithFetchAction(false);
+
+        assertEquals(ItemViewType.STATUS, section.getItemViewType(1));
+        assertEquals(Collections.singleton(1), section.getItemDismissalGroup(1));
+    }
+
+    @Test
+    @Feature({"Ntp"})
+    public void testGetDismissalGroupActionAndHeader() {
+        SuggestionsSection section = createSectionWithFetchAction(false);
+        section.setHeaderVisibility(false);
+
+        assertEquals(ItemViewType.STATUS, section.getItemViewType(0));
+        assertEquals(Collections.singleton(0), section.getItemDismissalGroup(0));
+    }
+
+    @Test
+    @Feature({"Ntp"})
     public void testAddSuggestionsNotification() {
         final int suggestionCount = 5;
         List<SnippetArticle> snippets = createDummySuggestions(suggestionCount,
                 TEST_CATEGORY_ID);
 
         SuggestionsSection section = createSectionWithFetchAction(false);
         // Simulate initialisation by the adapter. Here we don't care about the notifications, since
         // the RecyclerView will be updated through notifyDataSetChanged.
         section.setStatus(CategoryStatus.AVAILABLE);
         reset(mParent);
@@ skipping 596 matching lines @@
 
     private static void verifySnippets(SuggestionsSection section, List<SnippetArticle> snippets) {
         assertEquals(snippets.size(), section.getSuggestionsCount());
         // Indices in section are off-by-one (index 0 is the header).
         int index = 1;
         for (SnippetArticle snippet : snippets) {
             assertEquals(snippet, section.getSuggestionAt(index++));
         }
     }
 }