Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2706063002: 📰 Make the section dismissal range dynamic (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index d249886790aeb694d59cc66d404b2ca768889ced..058159733c2bbecfe0ca8f7156922c3deb127ecd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -37,8 +37,6 @@
public class SuggestionsSection extends InnerNode {
private static final String TAG = "NtpCards";
- private static final Set<Integer> SECTION_DISMISSAL_GROUP = new HashSet<>(Arrays.asList(1, 2));
-
private final Delegate mDelegate;
private final SuggestionsCategoryInfo mCategoryInfo;
private final OfflinePageBridge mOfflinePageBridge;
@@ -489,14 +487,11 @@ public void setHeaderVisibility(boolean headerVisibility) {
private Set<Integer> getSectionDismissalRange() {
if (hasSuggestions()) return Collections.emptySet();
- if (!mMoreButton.isVisible()) {
- assert getStartingOffsetForChild(mStatus) == 1;
- return Collections.singleton(1);
- }
+ int statusCardIndex = getStartingOffsetForChild(mStatus);
+ if (!mMoreButton.isVisible()) return Collections.singleton(statusCardIndex);
- assert SECTION_DISMISSAL_GROUP.contains(getStartingOffsetForChild(mStatus));
- assert SECTION_DISMISSAL_GROUP.contains(getStartingOffsetForChild(mMoreButton));
- return SECTION_DISMISSAL_GROUP;
+ assert statusCardIndex + 1 == getStartingOffsetForChild(mMoreButton);
+ return new HashSet<>(Arrays.asList(statusCardIndex, statusCardIndex + 1));
}
public SuggestionsCategoryInfo getCategoryInfo() {
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698