Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&number=61782

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

Original issue's description:
> Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225
>
> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100, crashpad:157, crashpad:159, crashpad:161, crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100, crashpad:157, crashpad:159, crashpad:161, crashpad:162
Review-Url: https://codereview.chromium.org/2705373005
Cr-Commit-Position: refs/heads/master@{#452409}
Committed: https://chromium.googlesource.com/chromium/src/+/cc032bd4e8986d7c14c09d9a04c856395b90fe0b

[tzik, 2017-02-23 05:37:00]

Description was changed from

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}
==========

to

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

[tzik, 2017-02-23 05:37:00]

tzik@chromium.org changed reviewers:
+ isherman@chromium.org, mark@chromium.org, scottmg@chromium.org

[tzik, 2017-02-23 05:39:07]

Description was changed from

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

to

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

Original issue's description:
> Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225
>
> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

[tzik, 2017-02-23 05:39:56]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-02-23 05:40:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 05:41:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487828396705640, "parent_rev":
"8a75af1cd30519bd7205f0d9129eb8db8f29c48d", "commit_rev":
"cc032bd4e8986d7c14c09d9a04c856395b90fe0b"}

[commit-bot: I haz the power, 2017-02-23 05:42:18]

Description was changed from

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

Original issue's description:
> Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225
>
> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

to

==========
Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

Reason for revert:
This CL causes a mac compile failure:
https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&n...

../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused
variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused
variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^

Original issue's description:
> Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225
>
> 1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
>              Encoding
> c1b305244aba Update mig.py to take an explicit sdk argument
> d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
>              SSE context
> 0c322ecc3f71 Use zlib to gzip-compress uploads
> 546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
>              conversions
> 4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
> f34ed66b93a0 metrics: Record handler lifetime milestone events
> c1af20f1aa8a metrics: Consistently comment about enums used for metrics
> 9c8407123796 Fix warning when building with clang on Windows
> 6da9708e7cc9 doc: Fix Doxygen errors
>
> BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
>
> Review-Url: https://codereview.chromium.org/2710663006
> Cr-Commit-Position: refs/heads/master@{#452387}

TBR=mark@chromium.org, isherman@chromium.org, scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2705373005
Cr-Commit-Position: refs/heads/master@{#452409}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc032bd4e8986d7c14c09d9a04c8...
==========

[commit-bot: I haz the power, 2017-02-23 05:42:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc032bd4e8986d7c14c09d9a04c8...

[Mark Mentovai, 2017-02-23 13:09:45]

The fix was already in the CQ :(

https://codereview.chromium.org/2716563002/