Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: third_party/crashpad/crashpad/util/thread/thread_posix.cc

Issue 2705373005: Revert of Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225 (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/thread/thread_posix.cc
diff --git a/third_party/crashpad/crashpad/util/thread/thread_posix.cc b/third_party/crashpad/crashpad/util/thread/thread_posix.cc
index 58a9874766405132d58405db79c0bc6017f74e9b..7142c78685c6f2d6d62591a86b558ce04dd158b1 100644
--- a/third_party/crashpad/crashpad/util/thread/thread_posix.cc
+++ b/third_party/crashpad/crashpad/util/thread/thread_posix.cc
@@ -14,22 +14,20 @@
#include "util/thread/thread.h"
-#include <errno.h>
-
#include "base/logging.h"
namespace crashpad {
void Thread::Start() {
DCHECK(!platform_thread_);
- errno = pthread_create(&platform_thread_, nullptr, ThreadEntryThunk, this);
- PCHECK(errno == 0) << "pthread_create";
+ int rv = pthread_create(&platform_thread_, nullptr, ThreadEntryThunk, this);
+ PCHECK(0 == rv);
}
void Thread::Join() {
DCHECK(platform_thread_);
- errno = pthread_join(platform_thread_, nullptr);
- PCHECK(errno == 0) << "pthread_join";
+ int rv = pthread_join(platform_thread_, nullptr);
+ PCHECK(0 == rv);
platform_thread_ = 0;
}

Powered by Google App Engine
This is Rietveld 408576698