Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

InsertInto/DeleteFromTextNodeCommand used to update layout at the
end of doApply() and unApply(), which is bad because the client
of the clean layout is unclear, and unnecessary layout updates
may be performed.

This patch removes these layout update calls, and explicitly updates
layout before clients.

BUG=694816
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2705373002
Cr-Commit-Position: refs/heads/master@{#451936}
Committed: https://chromium.googlesource.com/chromium/src/+/7a0a5316f12d0873b3c17a29157b703cf4f1ae36

[Xiaocheng, 2017-02-21 23:53:59]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 23:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:59:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Xiaocheng, 2017-02-22 03:30:00]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 03:30:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-22 04:16:25]

Description was changed from

==========
Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand


BUG=694816
==========

to

==========
Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

InsertInto/DeleteFromTextNodeCommand used to update layout at the
end of doApply() and unApply(), which is bad because the client
of the clean layout is unclear, and unnecessary layout updates
may be performed.

This patch removes these layout update calls, and explicitly updates
layout before clients.

BUG=694816
TEST=n/a; no behavior change
==========

[Xiaocheng, 2017-02-22 04:16:25]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-02-22 04:16:31]

PTAL.

[commit-bot: I haz the power, 2017-02-22 05:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 05:23:32]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xiaocheng, 2017-02-22 05:43:28]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 05:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-22 06:25:54]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-22 06:26:08]

lgtm

Thanks for make world clean!

https://codereview.chromium.org/2705373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
(left):

https://codereview.chromium.org/2705373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp:180:
DCHECK(!textNode->layoutObject() ||
I really don't like this DCHECK() since it depends on how layout produces and
layering violation.
Also, we don't need to have this kind of DCHECK() here. Rather, we should have
unit test for 
|deleteInsignificantTextDownstream()|. (I don't ask you to write it)

[yosin_UTC9, 2017-02-22 06:26:10]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 08:42:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487744770218840,
"parent_rev": "65991e47712835e5e8f66d2223ba0f856c4e5819", "commit_rev":
"7a0a5316f12d0873b3c17a29157b703cf4f1ae36"}

[commit-bot: I haz the power, 2017-02-22 08:43:19]

Description was changed from

==========
Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

InsertInto/DeleteFromTextNodeCommand used to update layout at the
end of doApply() and unApply(), which is bad because the client
of the clean layout is unclear, and unnecessary layout updates
may be performed.

This patch removes these layout update calls, and explicitly updates
layout before clients.

BUG=694816
TEST=n/a; no behavior change
==========

to

==========
Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

InsertInto/DeleteFromTextNodeCommand used to update layout at the
end of doApply() and unApply(), which is bad because the client
of the clean layout is unclear, and unnecessary layout updates
may be performed.

This patch removes these layout update calls, and explicitly updates
layout before clients.

BUG=694816
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2705373002
Cr-Commit-Position: refs/heads/master@{#451936}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a0a5316f12d0873b3c17a29157b...
==========

[commit-bot: I haz the power, 2017-02-22 08:43:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a0a5316f12d0873b3c17a29157b...