third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp - Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand (Closed)

Patch Set: Add layout updates for clients requiring that explicitly Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

index 1c470e02411be25118b5135c1d47590aa9acadb0..5999ce1559e1c3843df68b08bac1c5f17b7d423f 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp

@@ -63,7 +63,6 @@ void InsertIntoTextNodeCommand::doApply(EditingState*) {

}

m_node->insertData(m_offset, m_text, IGNORE_EXCEPTION_FOR_TESTING);

- document().updateStyleAndLayout();

}

void InsertIntoTextNodeCommand::doUnapply() {

@@ -71,7 +70,6 @@ void InsertIntoTextNodeCommand::doUnapply() {

return;

m_node->deleteData(m_offset, m_text.length(), IGNORE_EXCEPTION_FOR_TESTING);

- document().updateStyleAndLayout();

}

DEFINE_TRACE(InsertIntoTextNodeCommand) {