third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp - Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

Issue 2705373002: Remove unnecessary layout updates from InsertInto/DeleteFromTextNodeCommand (Closed)

Patch Set: Add layout updates for clients requiring that explicitly Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

index acfcc177b9da0da78c71e832c41e9ec8531e5de2..b8170e7ca7636d9dd6dcfcef08506b019a21f080 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

@@ -177,8 +177,6 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {

Position positionBeforeTextNode(Position::inParentBeforeNode(*textNode));

// Clear out all whitespace and insert one non-breaking space

deleteInsignificantTextDownstream(endingPosition);

- DCHECK(!textNode->layoutObject() ||

yosin_UTC9 2017/02/22 06:26:08 I really don't like this DCHECK() since it depends

- textNode->layoutObject()->style()->collapseWhiteSpace());

// Deleting insignificant whitespace will remove textNode if it contains

// nothing but insignificant whitespace.

if (textNode->isConnected()) {