Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/browser/chromeos/login/screens/base_screen_delegate.h

Issue 2705363002: cros: Move BaseScreenDelegate::ExitCodes into separate file, ScreenExitCode. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/base_screen_delegate.h
diff --git a/chrome/browser/chromeos/login/screens/base_screen_delegate.h b/chrome/browser/chromeos/login/screens/base_screen_delegate.h
index 1bc19b7c286859744a4ddf07e1ec27d0bc39b636..bfa667a376de199dd0a81e835bf7270e89e9dc93 100644
--- a/chrome/browser/chromeos/login/screens/base_screen_delegate.h
+++ b/chrome/browser/chromeos/login/screens/base_screen_delegate.h
@@ -7,6 +7,8 @@
#include <string>
+#include "chrome/browser/chromeos/login/screens/screen_exit_code.h"
+
namespace login {
class ScreenContext;
}
@@ -20,47 +22,9 @@ class ErrorScreen;
// screens.
class BaseScreenDelegate {
public:
- // Each login screen or a view shown within login wizard view is itself a
- // state. Upon exit each view returns one of the results by calling OnExit()
- // method. Depending on the result and the current view or state login wizard
- // decides what is the next view to show. There must be an exit code for each
- // way to exit the screen for each screen. (Numeric ids are provided to
- // facilitate interpretation of log files only, they are subject to change
- // without notice.)
- enum ExitCodes {
- // "Continue" was pressed on network screen and network is online.
- NETWORK_CONNECTED = 0,
- HID_DETECTION_COMPLETED = 1,
- // Connection failed while trying to load a WebPageScreen.
- CONNECTION_FAILED = 2,
- UPDATE_INSTALLED = 3,
- UPDATE_NOUPDATE = 4,
- UPDATE_ERROR_CHECKING_FOR_UPDATE = 5,
- UPDATE_ERROR_UPDATING = 6,
- USER_IMAGE_SELECTED = 7,
- EULA_ACCEPTED = 8,
- EULA_BACK = 9,
- ENTERPRISE_AUTO_ENROLLMENT_CHECK_COMPLETED = 10,
- ENTERPRISE_ENROLLMENT_COMPLETED = 11,
- ENTERPRISE_ENROLLMENT_BACK = 12,
- RESET_CANCELED = 13,
- KIOSK_AUTOLAUNCH_CANCELED = 14,
- KIOSK_AUTOLAUNCH_CONFIRMED = 15,
- KIOSK_ENABLE_COMPLETED = 16,
- TERMS_OF_SERVICE_DECLINED = 17,
- TERMS_OF_SERVICE_ACCEPTED = 18,
- WRONG_HWID_WARNING_SKIPPED = 19,
- CONTROLLER_PAIRING_FINISHED = 20,
- ENABLE_DEBUGGING_FINISHED = 21,
- ENABLE_DEBUGGING_CANCELED = 22,
- ARC_TERMS_OF_SERVICE_FINISHED = 23,
- UPDATE_ERROR_UPDATING_CRITICAL_UPDATE = 24,
- EXIT_CODES_COUNT // not a real code, must be the last
- };
-
// Method called by a screen when user's done with it.
virtual void OnExit(BaseScreen& screen,
- ExitCodes exit_code,
+ ScreenExitCode exit_code,
const ::login::ScreenContext* context) = 0;
// Forces current screen showing.

Powered by Google App Engine
This is Rietveld 408576698