Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
TBR=ben
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2705333006
Cr-Commit-Position: refs/heads/master@{#458557}
Committed: https://chromium.googlesource.com/chromium/src/+/a713ef602b71c72b903539abf21e6f9f10d21915

[Julien Isorce, 2017-02-23 14:09:16]

Description was changed from

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
==========

to

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-02-24 11:23:01]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 11:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce, 2017-02-24 11:23:35]

Hi David, please take a look. Thx.

[Julien Isorce, 2017-02-24 11:39:31]

On 2017/02/24 11:23:35, Julien Isorce wrote:
> Hi David, please take a look. Thx.

I should have added that this CL will allow calling
ui::ClientNativePixmapFactory::GetInstance()->ImportFromHandle from
GpuMemoryBufferImpl[-Ozone]NativePixmap::CreateFromHandle.

[commit-bot: I haz the power, 2017-02-24 12:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 12:12:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[spang, 2017-02-27 18:49:04]

spang@chromium.org changed reviewers:
+ spang@chromium.org

[spang, 2017-02-27 18:49:05]

https://codereview.chromium.org/2705333006/diff/20001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/2705333006/diff/20001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:156: visibility += [
This is definitely not OK.

:platform is for platform tests only as it exposes a non-componentized version
of ozone. Depending on this directly from the listed components will cause ODR
violations.

[reveman, 2017-03-08 16:41:56]

lgtm

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap.h (right):

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap.h:15: class GFX_EXPORT ClientNativePixmap {
Would be nice to rename this and relevant classes to something like DmaBufHolder
in a follow up if this is now specific to dmabufs.

[spang, 2017-03-08 17:43:44]

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap.h (right):

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap.h:15: class GFX_EXPORT ClientNativePixmap {
On 2017/03/08 16:41:55, reveman wrote:
> Would be nice to rename this and relevant classes to something like
DmaBufHolder
> in a follow up if this is now specific to dmabufs.

There's nothing in here that is specific to dmabufs. This is for anything that
supports import and mmap.

[reveman, 2017-03-09 12:10:48]

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap.h (right):

https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap.h:15: class GFX_EXPORT ClientNativePixmap {
On 2017/03/08 at 17:43:44, spang wrote:
> On 2017/03/08 16:41:55, reveman wrote:
> > Would be nice to rename this and relevant classes to something like
DmaBufHolder
> > in a follow up if this is now specific to dmabufs.
> 
> There's nothing in here that is specific to dmabufs. This is for anything that
supports import and mmap.

There's the SYNC_START/END logic.
https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/common/client_nati...

Maybe we don't even need a "holder" class on the client side but can just move
this into the GMB impl. I think it would be nice to have this logic in a
gpu_memory_buffer_impl_linux_dmabuf.cc file and no longer be tied up in ozone
specific code. One layer less of abstraction..

[spang, 2017-03-09 17:27:37]

On 2017/03/09 12:10:48, reveman wrote:
>
https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
> File ui/gfx/client_native_pixmap.h (right):
> 
>
https://codereview.chromium.org/2705333006/diff/20001/ui/gfx/client_native_pi...
> ui/gfx/client_native_pixmap.h:15: class GFX_EXPORT ClientNativePixmap {
> On 2017/03/08 at 17:43:44, spang wrote:
> > On 2017/03/08 16:41:55, reveman wrote:
> > > Would be nice to rename this and relevant classes to something like
> DmaBufHolder
> > > in a follow up if this is now specific to dmabufs.
> > 
> > There's nothing in here that is specific to dmabufs. This is for anything
that
> supports import and mmap.
> 

Oh, yes of course the dmabuf class is dmabuf specific. What I meant was that
client_native_pixmap.h itself isn't specific to dmabuf.

> There's the SYNC_START/END logic.
>
https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/common/client_nati...
> 
> Maybe we don't even need a "holder" class on the client side but can just move
> this into the GMB impl. I think it would be nice to have this logic in a
> gpu_memory_buffer_impl_linux_dmabuf.cc file and no longer be tied up in ozone
> specific code. One layer less of abstraction..

Only if we move GMBImpl to a more appropriate place (e.g., where native pixmap
is going here). Native pixmap is a place that works for ozone, and GMBImpl is
not. I don't think we will make progress on deduping this without moving
GMBImpl.

If it can't move, then I think we really are stuck with the duplication.

[Julien Isorce, 2017-03-10 15:57:58]

Description was changed from

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-03-10 16:00:18]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 16:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce, 2017-03-10 16:55:51]

Hi spang@, I addressed your remark, please have a look. Thx.

https://codereview.chromium.org/2705333006/diff/20001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/2705333006/diff/20001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:156: visibility += [
On 2017/02/27 18:49:05, spang wrote:
> This is definitely not OK.
> 
> :platform is for platform tests only as it exposes a non-componentized version
> of ozone. Depending on this directly from the listed components will cause ODR
> violations.

Done.

[commit-bot: I haz the power, 2017-03-10 17:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:12:04]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-14 17:04:57]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 18:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:27:18]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-14 19:24:33]

Description was changed from

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-03-14 19:24:33]

julien.isorce@chromium.org changed reviewers:
+ dnicoara@chromium.org

[spang, 2017-03-15 20:27:24]

Looks better, but there are still issues.

https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap_factory.cc (right):

https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap_factory.cc:28: #if !defined(OS_LINUX) &&
!defined(USE_OZONE)
This looks weird to me ... is this file actually getting compiled on !linux ? I
don't think it should be.

https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
File ui/ozone/public/client_native_pixmap_factory.cc (right):

https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
ui/ozone/public/client_native_pixmap_factory.cc:15:
ClientNativePixmapFactory::Create() {
Please don't implement the same function in two different components.

The header is in //ui/gfx but the implementation is in //ui/ozone. It can cause
link errors or other weirdness.

We don't need to have the same factory function for ozone and !ozone, you should
instead use two different declarations and #ifdef the call site.

[Julien Isorce, 2017-03-17 17:08:35]

On 2017/03/15 20:27:24, spang wrote:
> Looks better, but there are still issues.
> 
>
https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
> File ui/gfx/client_native_pixmap_factory.cc (right):
> 
>
https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
> ui/gfx/client_native_pixmap_factory.cc:28: #if !defined(OS_LINUX) &&
> !defined(USE_OZONE)
> This looks weird to me ... is this file actually getting compiled on !linux ?
I
> don't think it should be.
> 
>
https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
> File ui/ozone/public/client_native_pixmap_factory.cc (right):
> 
>
https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
> ui/ozone/public/client_native_pixmap_factory.cc:15:
> ClientNativePixmapFactory::Create() {
> Please don't implement the same function in two different components.
> 
> The header is in //ui/gfx but the implementation is in //ui/ozone. It can
cause
> link errors or other weirdness.
> 
> We don't need to have the same factory function for ozone and !ozone, you
should
> instead use two different declarations and #ifdef the call site.

Thx for the review. I am not sure how to do it at the moment. The one in ui/gfx
has to be the same type of these in ui/ozone, i.e "ClientNativePixmapFactory".
Because later on it will need to call IsConfigurationSupported, ImportFromHandle
on it. Maybe you were thinking to still move client_native_pixmap_factory.h to
ui/gfx but just have a different name for the Create function. If yes maybe I
see now how to do it so with a new header and class in ozone: 
client_native_pixmap_factory_ozone.h which just declares
ClientNativePixmapFactoryOzone::Create ? And should I just remove
ClientNativePixmapFactory::Create ?

[spang, 2017-03-17 17:34:42]

On 2017/03/17 17:08:35, Julien Isorce wrote:
> On 2017/03/15 20:27:24, spang wrote:
> > Looks better, but there are still issues.
> > 
> >
>
https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
> > File ui/gfx/client_native_pixmap_factory.cc (right):
> > 
> >
>
https://codereview.chromium.org/2705333006/diff/60001/ui/gfx/client_native_pi...
> > ui/gfx/client_native_pixmap_factory.cc:28: #if !defined(OS_LINUX) &&
> > !defined(USE_OZONE)
> > This looks weird to me ... is this file actually getting compiled on !linux
?
> I
> > don't think it should be.
> > 
> >
>
https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
> > File ui/ozone/public/client_native_pixmap_factory.cc (right):
> > 
> >
>
https://codereview.chromium.org/2705333006/diff/60001/ui/ozone/public/client_...
> > ui/ozone/public/client_native_pixmap_factory.cc:15:
> > ClientNativePixmapFactory::Create() {
> > Please don't implement the same function in two different components.
> > 
> > The header is in //ui/gfx but the implementation is in //ui/ozone. It can
> cause
> > link errors or other weirdness.
> > 
> > We don't need to have the same factory function for ozone and !ozone, you
> should
> > instead use two different declarations and #ifdef the call site.
> 
> Thx for the review. I am not sure how to do it at the moment. The one in
ui/gfx
> has to be the same type of these in ui/ozone, i.e "ClientNativePixmapFactory".
> Because later on it will need to call IsConfigurationSupported,
ImportFromHandle
> on it. Maybe you were thinking to still move client_native_pixmap_factory.h to
> ui/gfx but just have a different name for the Create function. If yes maybe I
> see now how to do it so with a new header and class in ozone: 
> client_native_pixmap_factory_ozone.h which just declares
> ClientNativePixmapFactoryOzone::Create ? And should I just remove
> ClientNativePixmapFactory::Create ?

Yes, probably remove that function and add a new header with something like

  CreateClientNativePixmapFactoryOzone();

[Julien Isorce, 2017-03-20 17:59:14]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 17:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:05:55]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-20 19:10:33]

On 2017/03/17 17:34:42, spang wrote:
> Yes, probably remove that function and add a new header with something like
> 
>   CreateClientNativePixmapFactoryOzone();

Done, please have a look, thx!

[spang, 2017-03-20 19:13:45]

lgtm

[Julien Isorce, 2017-03-20 19:23:20]

julien.isorce@chromium.org changed reviewers:
+ rjkroege@chromium.org

[Julien Isorce, 2017-03-20 19:23:46]

Hi rjkroege@ please take a look, thx.

[rjkroege, 2017-03-21 16:41:08]

lgtm

https://codereview.chromium.org/2705333006/diff/80001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap_factory.cc (left):

https://codereview.chromium.org/2705333006/diff/80001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap_factory.cc:32: // static
This particular trace is handled elsewhere? Or have you removed it?

https://codereview.chromium.org/2705333006/diff/80001/ui/ozone/public/client_...
File ui/ozone/public/client_native_pixmap_factory_ozone.cc (right):

https://codereview.chromium.org/2705333006/diff/80001/ui/ozone/public/client_...
ui/ozone/public/client_native_pixmap_factory_ozone.cc:13:
std::unique_ptr<ClientNativePixmapFactory>
ah! Ignore my previous concern about where the tracing went.

[Julien Isorce, 2017-03-21 17:39:46]

https://codereview.chromium.org/2705333006/diff/80001/ui/ozone/public/client_...
File ui/ozone/public/client_native_pixmap_factory_ozone.cc (right):

https://codereview.chromium.org/2705333006/diff/80001/ui/ozone/public/client_...
ui/ozone/public/client_native_pixmap_factory_ozone.cc:13:
std::unique_ptr<ClientNativePixmapFactory>
On 2017/03/21 16:41:08, rjkroege wrote:
> ah! Ignore my previous concern about where the tracing went.

Thx for the review. I noticed that I should rename
"ClientNativePixmapFactory::Create" to "CreateClientNativePixmapFactoryOzone". I
will upload the change.

[Julien Isorce, 2017-03-21 17:46:59]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 17:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julien Isorce, 2017-03-21 17:48:10]

julien.isorce@chromium.org changed reviewers:
+ sadrul@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:00:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:00:12]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-21 19:21:13]

Hi sadrul@, please take a look. Thx!

[sadrul, 2017-03-21 19:52:49]

lgtm

[Julien Isorce, 2017-03-21 20:06:59]

The CQ bit was checked by julien.isorce@chromium.org

[Julien Isorce, 2017-03-21 20:07:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, rjkroege@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2705333006/#ps100001
(title: "Fix trace")

[commit-bot: I haz the power, 2017-03-21 20:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:19:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce, 2017-03-21 20:33:03]

julien.isorce@chromium.org changed reviewers:
+ ben@chromium.org, piman@chromium.org

[Julien Isorce, 2017-03-21 20:35:20]

On 2017/03/21 20:19:58, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/browser_main_loop.cc
    content/renderer/renderer_main.cc
    services/ui/service.cc
    services/ui/service.h

Hi piman@, please take a look to content/*, thx.
Hi ben@, please take a look to services/*, thx.

[spang, 2017-03-21 21:22:33]

Description was changed from

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
TBR=ben
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[spang, 2017-03-21 21:22:40]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:23:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spang, 2017-03-21 21:26:44]

On 2017/03/21 20:35:20, Julien Isorce wrote:
> On 2017/03/21 20:19:58, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     content/browser/browser_main_loop.cc
>     content/renderer/renderer_main.cc
>     services/ui/service.cc
>     services/ui/service.h
> 
> Hi piman@, please take a look to content/*, thx.
> Hi ben@, please take a look to services/*, thx.

I'm not sure you need it, there is a narrow TBR exception for propagating
trivial API changes like this to clients.

[piman, 2017-03-21 21:27:58]

content/ rs lgtm

[commit-bot: I haz the power, 2017-03-21 21:38:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490131360252990,
"parent_rev": "e7398c55e00a085cc03f10e16f3f42fe37f980ac", "commit_rev":
"a713ef602b71c72b903539abf21e6f9f10d21915"}

[commit-bot: I haz the power, 2017-03-21 21:39:10]

Description was changed from

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
TBR=ben
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Move it along other native_pixmap api in ui/gfx

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
TBR=ben
R=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2705333006
Cr-Commit-Position: refs/heads/master@{#458557}
Committed:
https://chromium.googlesource.com/chromium/src/+/a713ef602b71c72b903539abf21e...
==========

[commit-bot: I haz the power, 2017-03-21 21:39:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a713ef602b71c72b903539abf21e...